Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R24.5][Bug] Available parts filter is falsely reset #958

Closed
ds-crehm opened this issue May 10, 2024 · 2 comments · Fixed by catenax-ng/tx-traceability-foss#1246
Closed
Assignees
Labels
bug Something isn't working public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path

Comments

@ds-crehm
Copy link
Contributor

Description

Happened on E2E-A:
When creating a notification directly, initially the type investigation is selected. This means, that the table of available parts is filtered to only show supplier parts, because an investigation may not have own parts.
However, when adding a part and then removing it again, the filter is not set anymore. Now all of the parts are shown again (including own parts). Then the user can select own parts and create an investigation with own parts. This investigation can even be successfully sent.

Current behaviour

When creating a notification from the Quality notifications tab directly, it looks like this initially:
Image
It only shows supplier parts in the second table.
Then I add one of the parts:
Image
The selected part is removed from the lower table and added to the upper table.
When I remove the selected part from the upper table again, the filter in the lower table is removed and all parts are shown:
Image

Expected behavior

During the creation of a notification, when an alert / investigation is selected, only the relevant available parts are shown at all times.

Steps to reproduce the Bug

  1. Go to quality notification tab
  2. Click "Create quality notification"
  3. Add part from lower table
  4. Remove the same part again
@ds-crehm ds-crehm added this to Trace-X May 10, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X May 10, 2024
@ds-crehm ds-crehm added the bug Something isn't working label May 10, 2024
@ds-crehm ds-crehm mentioned this issue May 13, 2024
4 tasks
@mkanal mkanal added R24.5 release-hot-fix pbi is relevant for current release and for hotfix path labels May 13, 2024
@ds-mwesener ds-mwesener moved this from inbox to next in Trace-X May 14, 2024
@ds-mwesener ds-mwesener moved this from next to wip in Trace-X May 14, 2024
@mkanal mkanal reopened this May 14, 2024
@mkanal mkanal changed the title [Bug] Available parts filter is falsely reset [R24.5][Bug] Available parts filter is falsely reset May 14, 2024
@ds-mwesener ds-mwesener moved this from wip to test in Trace-X May 14, 2024
@ds-crehm
Copy link
Contributor Author

Tested on E2E-A & E2E-B:
Works as expected now. Table is always filtered for appropriate parts depending on the type of notification (alert -> own parts, investigation -> supplier parts). When adding / removing parts, the filter is unchanged.
Ready for review.

@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm May 15, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X May 15, 2024
ds-mwesener pushed a commit that referenced this issue May 15, 2024
…ugfix

chore(bug): #958 bugfix filter reset of available parts
@mkanal
Copy link
Contributor

mkanal commented Jun 5, 2024

LGFM. PO acceptance in behalf of @jzbmw

@mkanal mkanal moved this from review to done in Trace-X Jun 5, 2024
@mkanal mkanal added the public public and not spammy label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

2 participants