Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UUX] Administrator - Notification creation/editing #995

Closed
3 tasks done
ds-crehm opened this issue May 16, 2024 · 7 comments · Fixed by catenax-ng/tx-traceability-foss#1278
Closed
3 tasks done

[UUX] Administrator - Notification creation/editing #995

ds-crehm opened this issue May 16, 2024 · 7 comments · Fixed by catenax-ng/tx-traceability-foss#1278
Assignees
@mkanal
Labels
frontend Frontend related Issues release-hot-fix pbi is relevant for current release and for hotfix path spillover temporary label for spill over uux UUX feedback and related topics

Comments

@ds-crehm
Copy link
Contributor

ds-crehm commented May 16, 2024 •
edited by mkanal
Loading

Hints / Details

R24.05 UUX feedback:

-- blocking --
Quality notifications – Received
Functionality Issue – signed in as role administrator this is unavailable with tooltip below
Same, e.g. when creating a quality alert. Get to the point of entering all data – but Save button is disabled (with role Admin) à should not be able to get to the entry screen in the first place
Image

Why can an admin not create/edit notifications?

Administrator can not create notifications from the quality notifications screen:
Image

But he can get to the "Create quality notification" screen through the parts page:
Image
The save button will not work in this case

Acceptance Criteria

  • 'Create quality notification' button in part table disabled for Administrator role
  • Prevent admin to get on edit and creation screen by URL
  • (alternatively) Make it possible for Administrators to create and edit notifications
@ds-crehm ds-crehm added this to Trace-X May 16, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X May 16, 2024
@ds-crehm ds-crehm added frontend Frontend related Issues DISCUSSION_NEEDED This ticket needs discussion within teammembers uux UUX feedback and related topics labels May 16, 2024
@ds-mwesener ds-mwesener mentioned this issue May 16, 2024
Closed
10 tasks
@ds-mmaul ds-mmaul self-assigned this May 17, 2024
@ds-mmaul ds-mmaul moved this from inbox to wip in Trace-X May 17, 2024
@ds-mmaul
Copy link
Contributor

done with catenax-ng#1258

@ds-mmaul ds-mmaul moved this from wip to test in Trace-X May 21, 2024
@ds-crehm
Copy link
Contributor Author

Tested on E2E: LGTM
Ready for review

@ds-crehm ds-crehm moved this from test to review in Trace-X May 22, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-mmaul May 22, 2024
@ds-lcapellino ds-lcapellino mentioned this issue May 22, 2024
Merged
2 tasks
@ds-crehm ds-crehm added release-hot-fix pbi is relevant for current release and for hotfix path and removed DISCUSSION_NEEDED This ticket needs discussion within teammembers labels May 27, 2024
@mkanal mkanal moved this from review to wip in Trace-X Jun 5, 2024
@mkanal
Copy link
Contributor

mkanal commented Jun 5, 2024 •
edited
Loading

@ds-mmaul
Disabling tooltip is missing if part is selected in table. Role admin does not get any info that function is disabled because of missing role.

image

@github-actions github-actions bot mentioned this issue Jun 5, 2024
Merged
@ds-mmaul
Copy link
Contributor

ds-mmaul commented Jun 5, 2024

@ds-mmaul Disabling tooltip is missing if part is selected in table. Role admin does not get any info that function is disabled because of missing role.

image

fixed with catenax-ng#1278

@ds-crehm ds-crehm assigned ds-mmaul and unassigned mkanal Jun 6, 2024
@ds-crehm ds-crehm moved this from wip to test in Trace-X Jun 6, 2024
@ds-crehm ds-crehm assigned ds-crehm and unassigned ds-mmaul Jun 6, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X Jun 6, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm Jun 6, 2024
@ds-crehm ds-crehm moved this from review to test in Trace-X Jun 6, 2024
@ds-crehm ds-crehm assigned ds-crehm and unassigned mkanal Jun 6, 2024
ds-jhartmann pushed a commit that referenced this issue Jun 10, 2024
@ds-mmaul
Merge pull request #1278 from catenax-ng/chore/#995-add-diabled-toolt…
2904b19 
…ip-to-notification-creation

chore(bug): #995 fix disabled tooltip for creation notification
@mkanal mkanal added the spillover temporary label for spill over label Jun 10, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X Jun 12, 2024
@ds-crehm
Copy link
Contributor Author

Tested locally with the updated branch.
This works correctly now. Even after selecting parts the tooltip about having the wrong role will show up.
Ready for review

@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm Jun 12, 2024
@ds-crehm ds-crehm reopened this Jun 13, 2024
@mkanal
Copy link
Contributor

mkanal commented Jun 17, 2024

Review:

  • Create Quality Alerts is enabled in case no data in Trace-X. Disabling tooltip with user information that no data is available.
    image

@mkanal
Copy link
Contributor

mkanal commented Jun 26, 2024

PO acceptance in behalf of @jzbmw
Admin has no possibility and right to edit or create notifications. LGFM

@mkanal mkanal closed this as completed Jun 26, 2024
@mkanal mkanal moved this from review to done in Trace-X Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkanal mkanal

Labels
frontend Frontend related Issues release-hot-fix pbi is relevant for current release and for hotfix path spillover temporary label for spill over uux UUX feedback and related topics
Projects
Trace-X
Status: done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(bug): #995 fix disabled tooltip for creation notification catenax-ng/tx-traceability-foss
3 participants
@mkanal @ds-mmaul @ds-crehm