Bug: Docker images are not tagged with release version

[paullatzelsperger]

Describe the bug

When creating a new release, for example 4.2.0, Docker images should be tagged with ...:4.2.0 (amongst others).
For some reason this does not happen.

To Reproduce

Create a new release version (DON'T DO THIS IN THE UPSTREAM!)

Expected behavior

the version tag is created

Screenshots/Error Messages

If applicable, add screenshots and/or error messages to help explain your problem.

Context Informations

first observed during the 0.3.3 release on April 19, 2023

Possible Implementation

My initial suspicion was, that either the docker/metadata-action does not pick up the newly created tag, or creating a tag does not trigger the build.yaml workflow.

On closer inspection, the reason turned out to be, that in order for workflows to be triggered from workflow runs, we apparently cannot use a GITHUB_TOKEN, but must use a PAT, according to the documentation. That means, that the workflow that creates the tag (i.e. publish_new_release.yaml) cannot run using a GITHUB_TOKEN, it must use a PAT, otherwise the other job, that publishes the image (build.yaml) won't execute. The solution could be as easy as to remove the permissions: block from the github-release job.

I tried it out by manually creating a Git tag, which did indeed trigger the workflow, and caused the correct Docker tag to be created.