chore: upstream some minor fixes necessary for creating releases #158
Conversation
paullatzelsperger
force-pushed
the
develop
branch
from
d2c9b15 to
d296201
Compare
| @@ -48,7 +48,7 @@ helm install my-release tractusx-edc/edc-controlplane --version 0.3.0 | |||
| | envSecretName | string | `nil` | [Kubernetes Secret Resource](https://kubernetes.io/docs/concepts/configuration/secret/) name to load environment variables from | | |||
| | fullnameOverride | string | `""` | Overrides the releases full name | | |||
| | image.pullPolicy | string | `"IfNotPresent"` | [Kubernetes image pull policy](https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy) to use | | |||
| | image.repository | string | `"ghcr.io/catenax-ng/product-edc/edc-controlplane-postgresql-hashicorp-vault"` | Which derivate of the edc control-plane to use. One of: [ghcr.io/catenax-ng/product-edc/edc-controlplane-postgresql-hashicorp-vault, ghcr.io/catenax-ng/product-edc/edc-controlplane-postgresql, ghcr.io/catenax-ng/product-edc/edc-controlplane-memory] | | |||
| | image.repository | string | `"ghcr.io/eclipse-tractusx/tractusx-edc/edc-controlplane-postgresql-hashicorp-vault"` | Which derivate of the edc control-plane to use. One of: [ghcr.io/eclipse-tractusx/tractusx-edc/edc-controlplane-postgresql-hashicorp-vault, ghcr.io/eclipse-tractusx/tractusx-edc/edc-controlplane-postgresql, ghcr.io/eclipse-tractusx/tractusx-edc/edc-controlplane-memory] | | |||
There was a problem hiding this comment.
Where will the new container images be release?
There was a problem hiding this comment.
they should go into upstream, i.e. tractusx-edc. to be fair, they are not there yet, but as soon as this PR is merged, i'll trigger a release, which will put them there.
There was a problem hiding this comment.
Hi @florianrusch-zf and @paullatzelsperger ,
images is eclipse-tractusx are private on default, and I think they will stay that way.
In the meantime we have the proper docs/notices/agreements, that we can publish images on DockerHub.
#149 was a precondition for that. So in my opinion you are good to go and publish on DockerHub, if you add the proper notice. Example: https://github.com/eclipse-tractusx/item-relationship-service#notice-for-docker-image
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
chore: upstream some minor fixes necessary for creating releases
WHAT
This pr adds some minor fixes and tweaks in preparation for releasing versions, such as adapting GH Actions workflows and adding some files needed for QGate evaluation.
WHY
Those changes are necessary for releasing versions and must thus be upstreamed.
IMPORTANT
This pull-request should be merged after catenax-ng#10 is merged, because that contains some last-minute fixes as well.[edit] This PR should also be merged after #134 to avoid duplicated workdone