You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is actually not fully correct. It does validate that the input follows the right notation but doesn't validate edge cases like mentioned in the case above.
To fix this, that method must be refactored to perform the complete validation, not just the format string.
While this issue can be solved without much thinking, extra attention should be used to verify the performance/thread safety of the implementation as the code can be on the "hot" path of the execution of a vert.x application.
We will be availabe to support new contributors to work on these issues!
The text was updated successfully, but these errors were encountered:
Currently, we skip about 300 tests from the TCK:
https://github.com/eclipse-vertx/vertx-json-schema/blob/master/src/test/resources/unsupported-tck-tests.properties
This is a general purpose issue to track pull request to address the issues. The issues should be considered "good first issue" kind of tasks.
To address an unsupported test, first one needs to understand the test, for example:
shows that the code we have here:
vertx-json-schema/src/main/java/io/vertx/json/schema/impl/Format.java
Lines 197 to 202 in cce9a61
Is actually not fully correct. It does validate that the input follows the right notation but doesn't validate edge cases like mentioned in the case above.
To fix this, that method must be refactored to perform the complete validation, not just the format string.
While this issue can be solved without much thinking, extra attention should be used to verify the performance/thread safety of the implementation as the code can be on the "hot" path of the execution of a vert.x application.
We will be availabe to support new contributors to work on these issues!
The text was updated successfully, but these errors were encountered: