Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PutBuilder/Publication have divergent implementations #633

Closed
fuzzypixelz opened this issue Dec 26, 2023 · 0 comments · Fixed by #634
Closed

PutBuilder/Publication have divergent implementations #633

fuzzypixelz opened this issue Dec 26, 2023 · 0 comments · Fixed by #634
Labels
bug Something isn't working

Comments

@fuzzypixelz
Copy link
Member

fuzzypixelz commented Dec 26, 2023

Describe the bug

PutBuilder's impl is sound, but Publication isn't as it doesn't take into consideration its SampleKind field.

To reproduce

git clone [email protected]:fuzzypixelz/zenoh.git -b doc-publisher-putbuilder-discrepancy
cd zenoh
# Should presumably be on the same network
cargo run --example z_write_delete # 1
cargo run --example z_sub_delete   # 2

Notice that (1) performs a PUT with SampleKind::Delete using the Publisher::write method but (2) receives a sample with kind SampleKind::Put.

System info

OS: macOS Ventura 13.6
CPU: Apple M1
Rev: d8c27a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant