You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of #752, the zenoh_macros::kedefine macro generates getters that return &zenoh_keyexpr::keyexpr for key expression format specs other than ** instead of returning Option<&zenoh_keyexpr::keyexpr> which was the behavior before the pull request in question was merged.
This is a breaking change for users of key expression format specs other than **, e.g. zenoh-plugin-ros1.
Otherwise if this change is intentional, the documentation should be updated to reflect it:
Parsed will have a method named after each spec's id that returns Option<&keyexpr>. That Option will only be None if the spec's format was ** and matched a sequence of 0 chunks.
I was unsatisfied with returning Options that would always be Some, so I opted for tanking the break. The generated docs for each individual method was updated, #783 updates the global docs :)
Describe the bug
As of #752, the
zenoh_macros::kedefine
macro generates getters that return&zenoh_keyexpr::keyexpr
for key expression format specs other than**
instead of returningOption<&zenoh_keyexpr::keyexpr>
which was the behavior before the pull request in question was merged.This is a breaking change for users of key expression format specs other than
**
, e.g. zenoh-plugin-ros1.zenoh_macros::kedefine
API zenoh-plugin-ros2dds#88zenoh_macros::kedefine
API zenoh-plugin-ros1#35@p-avital
To reproduce
System info
The text was updated successfully, but these errors were encountered: