-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved tabbed terminals design #1888
Comments
Design updated from discussion with @vparfonov |
Imagine that just one pane is shown with some tabs and user clicks Split pane button. |
"When a new pane is created, it always opens the last focused terminal." If user hits "Split pane", we always create the pane with a terminal and this terminal is having the focus. In the case of multi-machines, the new terminal will be from the same machine than the latest terminal focused by the user. |
And if the first pane is empty then new pane also should be empty. Am I right? |
@slemeur when you say |
You can consider opening a terminal from the dev-machine.
No, let's open a new terminal from the same machine than the latest terminal focused by the user. |
But actually this situation may happen when user click Close All Tabs In Pane.
So, the last focused terminal from the first pane should be closed? |
Even with that - you always had at least one terminal opened. Note that we should remind the source of the latest opened/used terminal even if this one has been closed by the user. It seems there is complexity on this behavior, if it is too tricky - start by just opening a terminal from the dev-machine each time a new pane is created. |
OK. Now it is more understandable ) And one more question. Issue description says: "The user can open the same terminal into multiple panes". |
In the version 4.5.0 we have integrated the new feature "Side by side terminals"
We have the basics of the functionality, but we now have to implement a proper design and user experience.
Here is the design:
![multiconsole](https://cloud.githubusercontent.com/assets/1636769/17031808/3f2d0978-4f76-11e6-8516-c7edd379dc44.png)
Focus
Terminal who is currently having the cursor is shown with:
New Terminal
A new terminal can be invoked by either clicking in the "+" button in the list of consoles or by executing a new command from the toolbar.
In this case, the new terminal/console is opened in the pane that was having the focus previously.
Pane Management
The management of panes is handled by a small button on the right of the tabs in the pane. When this button is clicked, it shows options:
When a new pane is created, it always opens a new terminal from the same machine than the latest terminal focused by the user.
Terminal tree
The terminal tree behaves like the project explorer. The user can open the same terminal into multiple panes.
Too much terminal in pane
When there are too many terminals in the pane, we do the same behavior than the one we have for the editor. We reuse the same button which is handling the pane management.
(Sample: 15 terminals opened in a pane, but space to display the tabs allow to display only 10, then we will have the other 5 terminals in the menu)
The text was updated successfully, but these errors were encountered: