Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing or editing a file containing line 'exit' kills the terminal #1979

Closed
vitaliy-guliy opened this issue Jul 28, 2016 · 4 comments
Closed
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Jul 28, 2016

Trying to view or edit a text file containing line 'exit' leads to closing the terminal.

Reproduction Steps:

  1. Create a project and a text file with line 'exit'
  2. Open a terminal and run Midnight commander
  3. Go to the text file and press F3 or F4

Expected behavior:

The file must be opened for edit or view.

Observed behavior:

The terminal is closed.

Che version: 4.6.0-SNAPSHOT
OS and version: Linux Mint 17.1 64 bit
Docker version: 1.10.3
Che install: server (zip)

Additional information:

  • Problem can be reliably reproduced, doesn't happen randomly: Yes

depends on #1518

@vitaliy-guliy vitaliy-guliy changed the title Viewing or editing a file containing Viewing or editing a file containing line 'exit' kills the terminal Jul 28, 2016
@vitaliy-guliy
Copy link
Contributor Author

killing-the-terminal

@ghost ghost added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 28, 2016
@sixtyeight
Copy link

even simpler to reproduce, just enter echo exitin the shell.

Version : 4.4.2
Revision : c3e34e105dcb86a3
Build Time :2016-07-06 08:16:23

@JamesDrummond
Copy link
Contributor

@eivantsov Can we assign this to someone yet?

@vkuznyetsov vkuznyetsov added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/enterprise labels Aug 11, 2016
@TylerJewell TylerJewell added this to the 5.1.0 milestone Dec 21, 2016
@AndrienkoAleksandr AndrienkoAleksandr added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Dec 22, 2016
@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Dec 26, 2016

Original issue description is not actual. Actual bug(for 5.0.0-M9-SNAPSHOT): terminal should be closed, when user typed "exit" (if terminal has no background processes which can catch it).

@AndrienkoAleksandr AndrienkoAleksandr added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Dec 30, 2016
@bmicklea bmicklea added the severity/P1 Has a major impact to usage or development of the system. label Jan 10, 2017
@bmicklea bmicklea removed this from the 5.1.0 milestone Jan 10, 2017
@AndrienkoAleksandr AndrienkoAleksandr added this to the 5.1.0 milestone Jan 11, 2017
@AndrienkoAleksandr AndrienkoAleksandr removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 16, 2017
@mmorhun mmorhun removed their assignment Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

8 participants