Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect factory validation behavior when field value matches default for its type #2022

Closed
mshaposhnik opened this issue Aug 2, 2016 · 3 comments
Closed

Incorrect factory validation behavior when field value matches default for its type #2022

mshaposhnik opened this issue Aug 2, 2016 · 3 comments
Assignees
@mshaposhnik
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone
4.7.0

Comments

@mshaposhnik
Copy link
Contributor

mshaposhnik commented Aug 2, 2016 •
edited
Loading

Factory validator fails when field value matches default for its type, e.g. if set boolean variable to false, ot intereger to 0e.t.c

Issue related to codenvy/codenvy#455

Reproduction Steps:
Try create factory with several machines described, when one of them has "dev" : false property.

Expected behavior:
Factory must be created

Observed behavior:
Factory validator throws error saying "dev" property is not set

Che version: 4.6.0

Additional information:

  • Problem started happening recently, didn't happen in an older version of Che: No
  • Problem can be reliably reproduced, doesn't happen randomly: Yes
mshaposhnik added a commit that referenced this issue Aug 2, 2016
@mshaposhnik
CHE-2022; fixed validation behavior when field value matches default …
60f4657 
…value for its type; Fixes #2022
mshaposhnik added a commit that referenced this issue Aug 2, 2016
@mshaposhnik
fixup! CHE-2022; fixed validation behavior when field value matches d…
cb3a38e 
…efault value for its type; Fixes #2022
@mshaposhnik mshaposhnik mentioned this issue Aug 2, 2016
Merged
mshaposhnik added a commit that referenced this issue Aug 2, 2016
@mshaposhnik
fixup! fixup! CHE-2022; fixed validation behavior when field value ma…
3ee95cd 
…tches default value for its type; Fixes #2022
@TylerJewell
Copy link

@mshaposhnik - should this belong in a different repository - /codenvy/codenvy

@mshaposhnik
Copy link
Contributor Author

@TylerJewell No - factory API is in Che.

@mshaposhnik mshaposhnik added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 2, 2016
@mshaposhnik mshaposhnik self-assigned this Aug 2, 2016
mshaposhnik added a commit that referenced this issue Aug 2, 2016
@mshaposhnik
fixup! fixup! fixup! CHE-2022; fixed validation behavior when field v…
fff134b 
…alue matches default value for its type; Fixes #2022
@bmicklea
Copy link

bmicklea commented Aug 5, 2016

@mshaposhnik was is merged into the 4.7.0 milestone? If so please add that milestone designation to this issue.

@mshaposhnik mshaposhnik added this to the 4.7.0 milestone Aug 5, 2016
@bmicklea bmicklea added the kind/bug Outline of a bug - must adhere to the bug report template. label Aug 9, 2016
@bmicklea bmicklea mentioned this issue Aug 9, 2016
Closed
89 tasks
ibuziuk added a commit to ibuziuk/che that referenced this issue Jan 25, 2018
@ibuziuk
openshift.io eclipse-che#2022: Missing goals for wildfly build / run …
9933086 
…commands

Signed-off-by: Ilya Buziuk <[email protected]>
ibuziuk added a commit to ibuziuk/che that referenced this issue Jan 25, 2018
@ibuziuk
openshift.io eclipse-che#2022: Missing goals for wildfly build / run …
11128c8 
…commands

Signed-off-by: Ilya Buziuk <[email protected]>
ibuziuk added a commit that referenced this issue Jan 29, 2018
@ibuziuk
openshift.io #2022: Missing goals for wildfly build / run commands
b769abd 
Signed-off-by: Ilya Buziuk <[email protected]>
ibuziuk added a commit that referenced this issue Jan 29, 2018
@ibuziuk
openshift.io #2022: Missing goals for wildfly build / run commands
f72bb69 
Signed-off-by: Ilya Buziuk <[email protected]>
Katka92 pushed a commit to Katka92/che that referenced this issue Jun 27, 2018
@ibuziuk
openshift.io eclipse-che#2022: Missing goals for wildfly build / run …
23769af 
…commands

Signed-off-by: Ilya Buziuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshaposhnik mshaposhnik

Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
3 participants
@TylerJewell @mshaposhnik @bmicklea