Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to connect to terminal if terminal agent not found in machine config #2472

Closed
ghost opened this issue Sep 16, 2016 · 2 comments
Closed

Do not try to connect to terminal if terminal agent not found in machine config #2472

ghost opened this issue Sep 16, 2016 · 2 comments
Assignees
@vitaliy-guliy
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone
5.0.0-M6

Comments

@ghost
Copy link

ghost commented Sep 16, 2016

When the terminal agent is missing in machine config, the IDE still tries to connect to a terminal. As a result, error messages pop up which is not a good user experience.

It would be good is the IDE checks if there's a terminal agent in the machine config and connects to it only if there's one.
@ghost ghost added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 16, 2016
@vparfonov
Copy link
Contributor

Nice catch

@ashumilova ashumilova added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/plugin and removed team/ide labels Sep 27, 2016
@vitaliy-guliy vitaliy-guliy added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Oct 5, 2016
@vitaliy-guliy
Copy link
Contributor

Spent 1d

@vitaliy-guliy vitaliy-guliy removed the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 10, 2016
@vitaliy-guliy vitaliy-guliy added this to the 5.0.0-M6 milestone Oct 10, 2016
@bmicklea bmicklea mentioned this issue Oct 28, 2016
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliy-guliy vitaliy-guliy

Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
5.0.0-M6
Development

No branches or pull requests
3 participants
@ashumilova @vparfonov @vitaliy-guliy