Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array format unsupported for environment in compose file #2624

Closed
ghost opened this issue Sep 28, 2016 · 4 comments
Closed

Array format unsupported for environment in compose file #2624

ghost opened this issue Sep 28, 2016 · 4 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Milestone

Comments

@ghost
Copy link

ghost commented Sep 28, 2016

Docker compose environment is accepted as array and dictionary - https://docs.docker.com/compose/compose-file/#/environment. However, array format is unsupported in Che.

Reproduction Steps:

  1. Create a workspace with the following compose file
services: 
 dev-machine: 
  image: codenvy/ubuntu_jdk8
  environment: 
   - MYSQL_ROOT_PASSWORD=root 
   - MYSQL_DATABASE=utqg 

Expected behavior:
Support dictionary and array.

environment:
  RACK_ENV: development
  SHOW: 'true'
  SESSION_SECRET:

environment:
  - RACK_ENV=development
  - SHOW=true
  - SESSION_SECRET

Observed behavior:


Parsing of recipe of environment 'wksp-rkq9' failed. Error: Parsing of environment configuration failed. Can not deserialize instance of java.util.LinkedHashMap out of START_ARRAY token
at [Source: java.io.StringReader@29a1353; line: 5, column: 4] (through reference chain: org.eclipse.che.api.environment.server.compose.model.ComposeEnvironmentImpl["services"]->java.util.LinkedHashMap["dev-machine"]->org.eclipse.che.api.environment.server.compose.model.ComposeServiceImpl["environment"])
@ghost ghost added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 28, 2016
@JamesDrummond
Copy link
Contributor

@TylerJewell Does this need to be put into 5.0.0-M5?

@TylerJewell
Copy link

Let R&D decide when they take it.

@bmicklea bmicklea added this to the 5.0.0-M6 milestone Oct 3, 2016
@vkuznyetsov vkuznyetsov added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. sprint/next team/enterprise labels Oct 11, 2016
@vkuznyetsov vkuznyetsov assigned dmytro-ndp and unassigned garagatyi and mmorhun Oct 11, 2016
@bmicklea bmicklea modified the milestones: 5.0.0-M7, 5.0.0-M6 Oct 11, 2016
@dmytro-ndp dmytro-ndp added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Oct 13, 2016
@dmytro-ndp dmytro-ndp changed the title Dictionary format unsupported for environment in compose file Array format unsupported for environment in compose file Oct 23, 2016
@dmytro-ndp
Copy link
Contributor

Error handling:
wrong_env_value_exception-24_10_2016

@dmytro-ndp dmytro-ndp added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Oct 24, 2016
@bmicklea bmicklea modified the milestones: 5.0.0-M6, 5.0.0-M7 Oct 25, 2016
@riuvshin
Copy link
Contributor

moved to M7

@riuvshin riuvshin modified the milestones: 5.0.0-M7, 5.0.0-M6 Oct 26, 2016
@dmytro-ndp dmytro-ndp removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

No branches or pull requests

8 participants