Adding owners for e2e directory.
#13457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytro-ndp
approved these changes
May 31, 2019
There was a problem hiding this comment.
@Ohrimenko1988 had asked to remove him from selenium/** as well.
|
In my opinion, we should remove @dmytro-ndp from code owners of this project, because he doesn't involve to this project. |
|
@Ohrimenko1988 is right. |
|
@Ohrimenko1988 I've removed Dmytro. Is there anything else we agreed on, or is this ready to merge (after the checks of course :-D)? |
benoitf
reviewed
Jun 5, 2019
.github/CODEOWNERS
Outdated
| @@ -67,3 +67,6 @@ deploy/openshift/templates/che-monitoring.yaml @skabashnyuk @metlos | |||
|
|
|||
| # selenium tests | |||
| selenium/** @musienko-maxim @dmytro-ndp @Ohrimenko1988 | |||
|
|
|||
| # e2e tests | |||
| e2e/** @musienko-maxim @Ohrimenko1988 @rhopp | |||
There was a problem hiding this comment.
FYI there is a missing end of line
Ohrimenko1988
approved these changes
Jun 5, 2019
Signed-off-by: Radim Hopp <[email protected]>
che-bot
added
the
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Radim Hopp [email protected]
What does this PR do?
Adds owners for
e2efolder containing Hapy Path E2E tests.What issues does this PR fix or reference?
Release Notes
Docs PR