Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E typescript] Fix plugins adding #13496

Merged
merged 2 commits into from
Jun 10, 2019
Merged

[E2E typescript] Fix plugins adding #13496

merged 2 commits into from
Jun 10, 2019

Conversation

Katka92
Copy link
Contributor

@Katka92 Katka92 commented Jun 7, 2019

What does this PR do?

Add possibility to add version to a plugin that should be added before workspace startup. The version is not mandatory.

@Katka92 Katka92 requested a review from vparfonov as a code owner June 7, 2019 13:03
@che-bot
Copy link
Contributor

che-bot commented Jun 7, 2019

Can one of the admins verify this patch?

@Katka92 Katka92 force-pushed the selen-fix-plugins branch from f7d380d to 129017b Compare June 7, 2019 13:04
@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@Katka92 Katka92 changed the title Selen fix plugins [E2E typescript] Fix plugins adding Jun 10, 2019
@Katka92
Copy link
Contributor Author

Katka92 commented Jun 10, 2019

ci-test

Ohrimenko1988 and others added 2 commits June 10, 2019 11:53
@Katka92 Katka92 force-pushed the selen-fix-plugins branch from 129017b to 4b0254d Compare June 10, 2019 09:53
@SkorikSergey
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 10, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13496
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1843//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@rhopp rhopp merged commit d48254f into eclipse-che:master Jun 10, 2019
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
@che-bot che-bot added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 27, 2019
@Katka92 Katka92 deleted the selen-fix-plugins branch March 3, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Katka92 @che-bot @musienko-maxim @SkorikSergey @Ohrimenko1988 @rhopp