Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13660 - Replace mentions of 'oAuth', by more accurate 'OAuth'. (See https://oauth.net/) #13664

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Jul 2, 2019

No description provided.

@che-bot
Copy link
Contributor

che-bot commented Jul 2, 2019

Can one of the admins verify this patch?

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Jul 2, 2019

Can one of the admins verify this patch?

@benoitf benoitf added this to the 7.1.0 milestone Jul 2, 2019
@benoitf
Copy link
Contributor

benoitf commented Jul 2, 2019

ci-build

@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@skabashnyuk
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 2, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13664
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor

@themr0c your changes is not possible to compile.
can you take a look?

12:32:54 /home/codenvy/workspace/che-pullrequests-test-ocp/wsmaster/che-core-api-auth/src/main/java/org/eclipse/che/security/oauth/OAuthAuthenticationService.java:37: warning: [OvershadowingSubclassFields] Overshadowing variables of superclass causes confusion and errors. This variable is overshadowing a variable in superclass:  Service
12:32:54   @Context protected UriInfo uriInfo;
12:32:54                              ^
12:32:54     (see http://errorprone.info/bugpattern/OvershadowingSubclassFields)
12:32:54 /home/codenvy/workspace/che-pullrequests-test-ocp/wsmaster/che-core-api-auth/src/main/java/org/eclipse/che/security/oauth/OAuthAuthenticatorTokenProvider.java:27: error: cannot find symbol
12:32:54     this.oAuthAuthenticatorProvider = oAuthAuthenticatorProvider;
12:32:54         ^
12:32:54   symbol: variable oAuthAuthenticatorProvider
12:32:54 /home/codenvy/workspace/che-pullrequests-test-ocp/wsmaster/che-core-api-auth/src/main/java/org/eclipse/che/security/oauth/OAuthAuthenticatorTokenProvider.java:33: error: cannot find symbol
12:32:54         oAuthAuthenticatorProvider.getAuthenticator(oauthProviderName);
12:32:54         ^
12:32:54   symbol:   variable oAuthAuthenticatorProvider
12:32:54   location: class OAuthAuthenticatorTokenProvider
12:32:54 2 errors
12:32:54 1 warning
12:32:54 [JENKINS] Archiving disabled

@themr0c
Copy link
Contributor Author

themr0c commented Jul 2, 2019

I had committed by mistake a change in a variable name. I fixed the error and amended the commit. Thank you @skabashnyuk and Jenkins.

@themr0c
Copy link
Contributor Author

themr0c commented Jul 2, 2019

Fixed eclipsefdn/eca issue.

@benoitf
Copy link
Contributor

benoitf commented Jul 3, 2019

ci-build

@skabashnyuk
Copy link
Contributor

ci-test

@skabashnyuk
Copy link
Contributor

@l0rd can we merge this pr at this moment or we'll postpone it after GA?

@che-bot
Copy link
Contributor

che-bot commented Jul 3, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13664
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@l0rd
Copy link
Contributor

l0rd commented Jul 3, 2019

@skabashnyuk PR was created yesterday so that's borderline. I am +1 if it's risk free from a QE point of view because. @rhopp if you see any risk merging this PR let's postpone it to 7.1.0, otherwise let's merge it to master.

@l0rd l0rd requested a review from rhopp July 3, 2019 14:35
@skabashnyuk
Copy link
Contributor

ci-test

Copy link
Contributor

@rhopp rhopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I got to this PR with such delay. Going through PR I think it's safe to merge in 7.0.

@che-bot
Copy link
Contributor

che-bot commented Jul 9, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13664
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@l0rd
Copy link
Contributor

l0rd commented Jul 9, 2019

Label do-not-merge/hold removed

@skabashnyuk
Copy link
Contributor

@eclipse/eclipse-che-qa can you take a look at the report?

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1890//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@skabashnyuk skabashnyuk merged commit 939dfbe into eclipse-che:master Jul 10, 2019
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants