-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #13660 - Replace mentions of 'oAuth', by more accurate 'OAuth'. (See https://oauth.net/) #13664
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
ci-build |
Can one of the admins verify this PR? |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
@themr0c your changes is not possible to compile.
|
I had committed by mistake a change in a variable name. I fixed the error and amended the commit. Thank you @skabashnyuk and Jenkins. |
…See https://oauth.net/) Signed-off-by: Fabrice Flore-Thébault <[email protected]>
Fixed eclipsefdn/eca issue. |
ci-build |
ci-test |
@l0rd can we merge this pr at this moment or we'll postpone it after GA? |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
@skabashnyuk PR was created yesterday so that's borderline. I am +1 if it's risk free from a QE point of view because. @rhopp if you see any risk merging this PR let's postpone it to 7.1.0, otherwise let's merge it to master. |
ci-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I got to this PR with such delay. Going through PR I think it's safe to merge in 7.0.
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Label |
@eclipse/eclipse-che-qa can you take a look at the report? |
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1890//Selenium_20tests_20report/) doesn't show any regression against this Pull Request. |
…See https://oauth.net/) (#13664) Signed-off-by: Fabrice Flore-Thébault <[email protected]>
No description provided.