Deprecate /api/devfile REST API

[skabashnyuk]

What does this PR do?

Deprecate /api/devfile REST API

What issues does this PR fix or reference?

need for #13867

Release Notes

n/a

Docs PR

n/a

[skabashnyuk]

ci-test

[metlos]

I'm generally OK with returning 400 with a meaningful error message but I think we should consider the following:

• we should remove the swagger docs from the methods
• what about returning 301 (or maybe even 308) instead?

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13868
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[skabashnyuk]

we should remove the swagger docs from the methods

ok

what about returning 301 (or maybe even 308) instead?

My intention was a bit different. It's not just to keep it working it's to identify a place what it used and fix it. I next release we want to remove this api at all because we have analog /api/workspace/devfile.

AFAIK there are no places where we use this api.

[skabashnyuk]

@rhopp @nickboldt @sleshchenko @mshaposhnik thoughts?

[nickboldt]

Please tweak the error messages to explain the need for the call to action, and to fix the English syntax.

[skabashnyuk]

@nickboldt your comments have been addressed

[skabashnyuk]

ci-test

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13868
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[skabashnyuk]

@nickboldt are you ok with the current state of pr?
@eclipse/eclipse-che-qa can I ignore results of crw-ci-e2e-happy-path-test ?

[SkorikSergey]

@eclipse/eclipse-che-qa can I ignore results of crw-ci-e2e-happy-path-test ?

Yes, it is test problem(20 sec was not enough for starting Java language server).

[skabashnyuk]

@nickboldt ping

[nickboldt]

+1

[nickboldt]

@skabashnyuk sorry for slow response. You'd do better to ping on MM, slack, IRC, hangouts or anything that doesn't produce email but a notification of unread messages. :)

Email is the thing I do LAST after all the other hailing frequencies are done.