Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code & test independent from environment and time of execution #14207

Merged
merged 5 commits into from
Aug 27, 2019
Merged

Make code & test independent from environment and time of execution #14207

merged 5 commits into from
Aug 27, 2019

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Aug 13, 2019 •
edited
Loading

What does this PR do?

Make code & test independent from result FileSystems.getDefault().getFileStores() since it may happen that it may change during test execution between FileStoresMeterBinder object creation and test code.

What issues does this PR fix or reference?

#14202

Release Notes

n/a

Docs PR

n/a

@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 13, 2019
@skabashnyuk
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 13, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14207

@che-bot
Copy link
Contributor

che-bot commented Aug 13, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14207
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor Author

crw-ci-test

@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 13, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14207

@che-bot
Copy link
Contributor

che-bot commented Aug 13, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14207

@che-bot
Copy link
Contributor

che-bot commented Aug 13, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14207
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

crw-ci-test

@dmytro-ndp
Copy link
Contributor

@skabashnyuk: there is build result for this PR https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/blue/organizations/jenkins/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/detail/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/67/pipeline

@che-bot
Copy link
Contributor

che-bot commented Aug 13, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@skabashnyuk skabashnyuk marked this pull request as ready for review August 26, 2019 07:50
@skabashnyuk skabashnyuk requested a review from metlos August 26, 2019 07:50
@skabashnyuk skabashnyuk changed the title Enabled more verbose logger to test che14202 Make code & test independent from environment and time of execution Aug 26, 2019
@skabashnyuk
Copy link
Contributor Author

ci-build

@skabashnyuk
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14207

@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

metlos
metlos reviewed Aug 26, 2019
View reviewed changes
Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the comment about switching on debug logging

core/che-core-metrics-core/src/test/resources/logback-test.xml Outdated Show resolved Hide resolved
@skabashnyuk
fixup! Make FileStoresMeterTest independent from FileSystems.getDefau…
d8641b1 
…lt().getFileStores() state

Signed-off-by: Sergii Kabashniuk <[email protected]>
@skabashnyuk
fixup! fixup! Make FileStoresMeterTest independent from FileSystems.g…
7c56005 
…etDefault().getFileStores() state

Signed-off-by: Sergii Kabashniuk <[email protected]>
@skabashnyuk
fixup! fixup! fixup! Make FileStoresMeterTest independent from FileSy…
02c020f 
…stems.getDefault().getFileStores() state

Signed-off-by: Sergii Kabashniuk <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14207

@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14207

@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@skabashnyuk
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 26, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14207

@skabashnyuk skabashnyuk merged commit 06017df into master Aug 27, 2019
@skabashnyuk skabashnyuk deleted the che14202 branch August 27, 2019 06:14
@che-bot che-bot added this to the 7.1.0 milestone Aug 27, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@skabashnyuk @che-bot @dmytro-ndp @metlos