Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Happy Path] Fix checking application readiness in HappyPath test #14381

Merged
merged 4 commits into from
Sep 2, 2019
Merged

[Happy Path] Fix checking application readiness in HappyPath test #14381

merged 4 commits into from
Sep 2, 2019

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

This PR moves the first checking application readiness to try-catch block.

@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe labels Aug 29, 2019
@che-bot che-bot added the kind/bug Outline of a bug - must adhere to the bug report template. label Aug 29, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 29, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14381

@che-bot
Copy link
Contributor

che-bot commented Aug 29, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@dmytro-ndp
Copy link
Contributor

@SkorikSergey: is it checked on OKD as well?

@SkorikSergey
Copy link
Contributor Author

@SkorikSergey: is it checked on OKD as well?

It checked on OKD on Che7-pr-happy-path-test-OKD job - https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Che7-pr-happy-path-test-OKD/908/.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Aug 29, 2019 •
edited
Loading

@SkorikSergey: thanks you for the answer.
IMHO, there are redundant messages Application is not yet ready for use, Application is ready for use. App url:http://routerx5w1jh0-che.10.0.150.69.nip.io in the log:

12:43:29   Validation of workspace start
12:43:30     ✓ Open workspace (1410ms)
12:44:41     ✓ Wait workspace running state (70106ms)
12:44:53     ✓ Wait until project is imported (12109ms)
12:44:53 
12:44:53   Language server validation
12:46:20     ✓ Java LS initialization (87526ms)
12:46:26     ✓ Error highlighting (5759ms)
12:46:31     ✓ Autocomplete (4837ms)
12:46:36     ✓ Suggestion (5163ms)
12:46:42     ✓ Codenavigation (6151ms)
12:46:42     - Yaml LS initialization
12:46:42 
12:46:42   Validation of workspace build and run
12:47:21     ✓ Build application (38436ms)
12:47:34 Application is not yet ready for use
12:47:35 Application is not yet ready for use
12:47:36 Application is not yet ready for use
12:47:37 Application is not yet ready for use
12:47:38 Application is not yet ready for use
12:47:39 Application is not yet ready for use
12:47:41 Application is ready for use. App url:http://routerx5w1jh0-che.10.0.150.69.nip.io
12:47:41     ✓ Run application (20696ms)
12:47:42     ✓ Check the running application (565ms)
12:47:42     ✓ Close preview widget (527ms)
12:47:49     ✓ Close the terminal running tasks (6640ms)
12:47:49 
12:47:49   Display source code changes in the running application
12:48:01     ✓ Change source code (12406ms)
12:48:38     ✓ Build application with changes (37050ms)
12:48:52 Application is not yet ready for use
12:48:53 Application is not yet ready for use
12:48:54 Application is not yet ready for use
12:48:55 Application is not yet ready for use
12:48:56 Application is not yet ready for use
12:48:57 Application is not yet ready for use
12:48:58 Application is not yet ready for use
12:48:59 Application is not yet ready for use
12:49:01 Application is ready for use. App url:http://routerx5w1jh0-che.10.0.150.69.nip.io
12:49:01     ✓ Run application with changes (22804ms)
12:49:02     ✓ Check changes are displayed (448ms)
12:49:04     ✓ Close preview widget (1880ms)
12:49:10     ✓ Close running terminal processes and tabs (6636ms)

It makes list of steps less clear. Do you really need to have them in the logs by default?

@Ohrimenko1988
Copy link
Contributor

On previous several planings, we discussed about making the output more informative. I have created issue for this task #13686 .
So logging is good. But on my opinion, we should discuss and choose how it will look like and after that create some class which will implement logging of different layers. And only after that apply it for some particular cases.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Aug 30, 2019 •
edited
Loading

@SkorikSergey: what about usage console.debug() in catch block?
Will message be printed by default?

@SkorikSergey
Copy link
Contributor Author

@SkorikSergey: what about usage console.debug() in catch block?
Will message be printed by default?

I will check it.

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14381

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14381

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

dmytro-ndp
dmytro-ndp approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test output looks good now, IMHO https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/blue/organizations/jenkins/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/detail/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/263/:
Screenshot from 2019-09-02 15-13-01

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14381

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@SkorikSergey SkorikSergey merged commit f2ad4fb into master Sep 2, 2019
@SkorikSergey SkorikSergey deleted the checkAppReadinessHappyPath branch September 2, 2019 13:26
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 2, 2019
@che-bot che-bot added this to the 7.1.0 milestone Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SkorikSergey @che-bot @dmytro-ndp @Ohrimenko1988