[E2E] Fixing bug in opening file. #14435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katka92
requested review from
l0rd,
musienko-maxim,
nickboldt,
Ohrimenko1988 and
rhopp
as code owners
Katka92
force-pushed
the
e2e_fix_opening_project
branch
from
f515013 to
7a923ea
Compare
che-bot
added
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Ohrimenko1988
approved these changes
Sep 5, 2019
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Signed-off-by: kkanova <[email protected]>
Katka92
force-pushed
the
e2e_fix_opening_project
branch
from
7a923ea to
b8a3ab5
Compare
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
crw-ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
rhopp
approved these changes
Sep 5, 2019
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The last changes created a bug in ProjectTree.ts file. This PR is fixing them.
When calling the
expandPathAndOpenFilemethod in ProjectTree.ts file, there was a problem with adding slashes, so the wrong css path was generated. Was:/projects:/projects//console-java-simple, should be:/projects:/projects/console-java-simple.One slash was added in
expandPathAndOpenFilemethod and the second slash was added ingetItemCssmethod, which was called inside the first one.As
getItemCssmethod may be used in other methods, I decided to change a logic inexpandPathAndOpenFile.