Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Grafana panels with workspace traces metrics #14500

Merged
merged 3 commits into from
Sep 12, 2019
Merged

Add Grafana panels with workspace traces metrics #14500

merged 3 commits into from
Sep 12, 2019

Conversation

mkuznyetsov
Copy link
Contributor

What does this PR do?

Add several panels to Grafana to observe Workspace API traces:
Screenshot from 2019-09-10 14-04-36

What issues does this PR fix or reference?

#13502

Release Notes

Docs PR

@mkuznyetsov mkuznyetsov self-assigned this Sep 10, 2019
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 10, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 10, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14500

@che-bot
Copy link
Contributor

che-bot commented Sep 10, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@skabashnyuk
Copy link
Contributor

@mkuznyetsov I would like to ask you for a couple of adjustments.

  • minimum values on panels. For the timers, it makes sense to set it to 0
  • add units of measurements
  • for all workspace start/stop related measurements in case of aggregation function (like rate) please use time window [1h]
  • On a new panel please use Null as zeoro configuration parameter

metlos
metlos reviewed Sep 11, 2019
View reviewed changes
Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to also add these to the helm chart?

If yes, then some of the charts need to be modified, because they're openshift specific (which makes sense in the openshift template ;) ).

Otherwise LGTM.

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Sep 11, 2019 •
edited
Loading

Do we plan to also add these to the helm chart?

Not as a part of this issue/pr.

@che-bot
Copy link
Contributor

che-bot commented Sep 11, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14500

@che-bot
Copy link
Contributor

che-bot commented Sep 11, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14500

@che-bot
Copy link
Contributor

che-bot commented Sep 11, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14500

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@mkuznyetsov
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@mkuznyetsov mkuznyetsov merged commit 8ab8c2a into master Sep 12, 2019
@mkuznyetsov mkuznyetsov deleted the che-13502 branch September 12, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@metlos metlos metlos left review comments

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@mkuznyetsov mkuznyetsov

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkuznyetsov @che-bot @skabashnyuk @metlos