Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS_SELENIUM] Increase logging of tests steps #14642

Merged
merged 11 commits into from
Sep 27, 2019
Merged

[TS_SELENIUM] Increase logging of tests steps #14642

merged 11 commits into from
Sep 27, 2019

Conversation

Ohrimenko1988
Copy link
Contributor

What does this PR do?

Increase logging of tests steps

What issues does this PR fix or reference?

Issue: #13686

Release Notes

Docs PR

@Ohrimenko1988 Ohrimenko1988 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Sep 24, 2019
rhopp
rhopp approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@rhopp rhopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
just one question: have you tried to look into how to get class/method name automatically? that way we wouldn't need to write the class/method name in the messages by ourselves...

e2e/tests/e2e_happy_path/HappyPath.spec.ts Show resolved Hide resolved
@Ohrimenko1988
Copy link
Contributor Author

@rhopp Yes, I tried to find a solution but I didn't find any appropriate solution for automation.

@rhopp
Copy link
Contributor

rhopp commented Sep 25, 2019

@rhopp Yes, I tried to find a solution but I didn't find any appropriate solution for automation.

In that case +1 from me ;-)

@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 25, 2019
@Ohrimenko1988
Copy link
Contributor Author

ci-test

@Ohrimenko1988
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 25, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 25, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@vkuznyetsov vkuznyetsov removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Sep 26, 2019
@Ohrimenko1988
Merge master and respolve conflict
d772e43 
Signed-off-by: Ihor Okhrimenko <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14642

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 27, 2019
@Ohrimenko1988 Ohrimenko1988 merged commit c51519e into master Sep 27, 2019
@Ohrimenko1988 Ohrimenko1988 deleted the selen-logger branch September 27, 2019 08:53
@che-bot che-bot added this to the 7.2.0 milestone Sep 27, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 27, 2019
@Ohrimenko1988 Ohrimenko1988 mentioned this pull request Sep 27, 2019
Merged
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhopp rhopp rhopp approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Ohrimenko1988 @rhopp @che-bot @vkuznyetsov