Fix new alpine based Dockerfile for Boot2Docker #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
lgtm |
|
LGTM |
|
@eivantsov Please take a look |
Signed-off-by: Mario Loriedo <[email protected]>
l0rd
force-pushed
the
fix-dockerfile-boot2docker
branch
from
bf199ab to
b1016b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add user
userto the groupusersthat happen to have gid 100 that correspond to docker group in a boot2docker VM.What issues does this PR fix or reference?
A permission issue when trying to access the docker socket
/var/run/docker.sockwhen running Che in a container using boot2docker.Tests written?
No
Please review Che's Contributing Guide for best practices.
Signed-off-by: Mario Loriedo [email protected]