Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-1893; fix authorization flow during clone from private repo #1905

Merged
merged 2 commits into from
Jul 22, 2016

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Jul 22, 2016

What does this PR do?

fixes authorization flow during clone from private repo (should show login proposal and auth window if agreed)

What issues does this PR fix or reference?

codenvy/codenvy#431

Tests written?

No

Docs requirements?

None

Please review Che's Contributing Guide for best practices.

@mshaposhnik
Copy link
Contributor Author

@skabashnyuk @vparfonov pls review

@skabashnyuk
Copy link
Contributor

ok. @vinokurig ?

@vinokurig
Copy link
Contributor

vinokurig commented Jul 22, 2016

OK for me

@mshaposhnik mshaposhnik merged commit 4fdecd8 into master Jul 22, 2016
@mshaposhnik mshaposhnik deleted the CHE-1893 branch July 22, 2016 12:25
@codenvy-ci
Copy link

@TylerJewell TylerJewell modified the milestone: 4.6.0 Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants