Launcher: stop che-server cleanly (fix #1949) #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Loriedo <[email protected]>
|
Can one of the admins verify this patch? |
|
lgtm +1 |
tolusha
pushed a commit
that referenced
this pull request
Aug 1, 2016
Signed-off-by: Mario Loriedo <[email protected]>
ShimonBenYair
pushed a commit
to ShimonBenYair/che
that referenced
this pull request
Aug 4, 2016
…#1956) Signed-off-by: Mario Loriedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve how
che.shis called to stop the Che server.What issues does this PR fix or reference?
Fix #1949
Previous Behavior
codenvy/che-launcher stopfailed to stop che-server cleanly and remove the container brutally.New Behavior
codenvy/che-launcher stoptry to stop che-server cleanly and if the timeout is reached an error message is printed.Tests written?
Yes
Docs requirements?
NO
Signed-off-by: Mario Loriedo [email protected]