Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-2618 Fix checkout with start point #2619

Merged
merged 2 commits into from
Sep 28, 2016
Merged

CHE-2618 Fix checkout with start point #2619

merged 2 commits into from
Sep 28, 2016

Conversation

mkuznyetsov
Copy link
Contributor

@mkuznyetsov mkuznyetsov commented Sep 27, 2016 •
edited
Loading

What does this PR do?

  • Fix usecase when specified branch already exists in remote repo (perform a simple checkount instead of checkout w/startpoint)
  • Add "startPoint" as a valid parameter to SourceStorageParametersValidator

What issues does this PR fix or reference?

#2618

@mkuznyetsov
Copy link
Contributor Author

@skabashnyuk @akorneta @vinokurig review please

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/537/

@vinokurig
Copy link
Contributor

Ok for me

@mkuznyetsov mkuznyetsov merged commit ef0cd15 into master Sep 28, 2016
@mkuznyetsov mkuznyetsov deleted the CHE-2618 branch September 29, 2016 12:21
@mkuznyetsov mkuznyetsov mentioned this pull request Sep 30, 2016
Closed
@bmicklea bmicklea added this to the 5.0.0-M5 milestone Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@vinokurig vinokurig vinokurig approved these changes

@akorneta akorneta akorneta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-M5
Development

Successfully merging this pull request may close these issues.
6 participants
@mkuznyetsov @codenvy-ci @vinokurig @skabashnyuk @akorneta @bmicklea