Add ability to configure machines inside stack definition [CHE-2515] #2734

olexii4 · 2016-10-07T14:43:41Z

What does this PR do?

Add ability to configure machines inside stack definition
#2515

#2727

codenvy-ci · 2016-10-07T15:30:54Z

Build # 660 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/660/ to view the results.

TylerJewell · 2016-10-07T15:33:34Z

@slemeur - are we calling them "environments" or should that label be changed to "Runtimes"?

codenvy-ci · 2016-10-09T16:42:11Z

Build # 662 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/662/ to view the results.

ashumilova · 2016-10-10T06:26:12Z

...spaces/workspace-details/list-commands/edit-command-dialog/edit-command-dialog.controller.ts

+
+/**
+ * @ngdoc controller
+ * @name list.environment.variables.controller:EditCommandDialogController


workspace.details.controller instead list.environment.variables

list.commands.controller instead list.environment.variables.controller ?

ashumilova · 2016-10-10T06:27:02Z

...rkspaces/workspace-details/list-commands/add-command-dialog/add-command-dialog.controller.ts

+
+/**
+ * @ngdoc controller
+ * @name list.environment.variables.controller:AddCommandDialogController


workspace.details.controller list.environment.variables

ashumilova · 2016-10-10T06:28:21Z

dashboard/src/app/workspaces/workspace-details/list-commands/list-commands.controller.ts

+    });
+  }
+
+  changePortSelection(name): void {


changePortSelection -> changeCommandSelection

ashumilova · 2016-10-10T06:28:41Z

dashboard/src/app/workspaces/workspace-details/list-commands/list-commands.controller.ts

+  /**
+   * Check all ports in list
+   */
+  selectAllPorts(): void {


selectAllCommands

ashumilova · 2016-10-10T06:29:03Z

dashboard/src/app/workspaces/workspace-details/list-commands/list-commands.controller.ts

+  /**
+   * Uncheck all ports in list
+   */
+  deselectAllPorts(): void {


deselectAllCommands

codenvy-ci · 2016-10-10T08:23:09Z

Build # 667 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/667/ to view the results.

codenvy-ci · 2016-10-10T09:12:12Z

Build # 668 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/668/ to view the results.

codenvy-ci · 2016-10-10T15:52:31Z

Build # 677 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/677/ to view the results.

codenvy-ci · 2016-10-20T17:40:45Z

Build # 754 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/754/ to view the results.

codenvy-ci · 2016-10-21T15:53:06Z

Build # 764 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/764/ to view the results.

codenvy-ci · 2016-10-25T11:25:30Z

Build # 785 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/785/ to view the results.

codenvy-ci · 2016-10-26T14:22:05Z

Build # 803 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/803/ to view the results.

ashumilova · 2016-10-27T10:00:45Z

.../src/app/stacks/stack-details/list-components/add-component-dialog/add-component-dialog.html

+                 che-form="addComponentForm"
+                 che-label-name="Name"
+                 che-name="name"
+                 che-place-holder="enter component's name"


enter component's name - Enter component's name

ashumilova · 2016-10-27T10:01:26Z

.../src/app/stacks/stack-details/list-components/add-component-dialog/add-component-dialog.html

+      <che-input che-form="addComponentForm"
+                 che-label-name="Version"
+                 che-name="version"
+                 che-place-holder="enter component's version"


enter component's version -> Enter component's version

ashumilova · 2016-10-27T10:03:19Z

...acks/stack-details/list-components/edit-component-dialog/edit-component-dialog.controller.ts

+ * @description This class is handling the controller for a dialog box about editing the stack's component.
+ * @author Oleksii Orel
+ */
+export class EditComponentDialogController {


we can use same widget for adding new and editing, cause they are the same.

ashumilova · 2016-10-27T10:05:08Z

dashboard/src/app/stacks/stack-details/list-components/list-components.controller.ts

+  }
+
+  /**
+   * Update the component


update doc header with params

ashumilova · 2016-10-27T10:11:32Z

...orkspaces/workspace-details/environments/add-machine-dialog/add-machine-dialog.controller.ts

+   * Update machine RAM.
+   */
+  updateMachineRAM() {
+    this.machineRecipe[Object.keys(this.machineRecipe)[0]]['mem_limit'] = this.machineRAM;


use EnvironmentManager when perform any actions or transformations on machine and environment.

ashumilova · 2016-10-27T10:13:23Z

...spaces/workspace-details/list-commands/edit-command-dialog/edit-command-dialog.controller.ts

+ * @description This class is handling the controller for a dialog box about editing the workspace's command.
+ * @author Oleksii Orel
+ */
+export class EditCommandDialogController {


the same as add command dialog

ashumilova · 2016-10-27T10:25:45Z

dashboard/src/components/api/che-stack.factory.ts

+      'description': 'New Java Stack',
+      'scope': 'general',
+      'tags': [
+        'Java 1.8'


this tag is not displayed in tags section on creation

it have fixed 74ccff2#diff-f32fbb5cbd6b9b53264cc71d6a04ef37R78

codenvy-ci · 2016-10-27T14:58:45Z

Build # 816 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/816/ to view the results.

…definition Signed-off-by: Oleksii Orel <[email protected]>

Signed-off-by: Oleksii Orel <[email protected]>

codenvy-ci · 2016-10-28T16:47:38Z

Build # 836 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/836/ to view the results.

codenvy-ci · 2016-10-28T18:13:05Z

Build # 839 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/839/ to view the results.

Add ability to configure machines inside stack definition [CHE-2515]

akurinnoy approved these changes Oct 7, 2016

View reviewed changes

olexii4 force-pushed the CHE-2515 branch from cdcabe7 to 39d7297 Compare October 9, 2016 16:06

benoitf approved these changes Oct 9, 2016

View reviewed changes

ashumilova reviewed Oct 10, 2016

View reviewed changes

benoitf changed the title ~~Che 2515~~ Add ability to configure machines inside stack definition [CHE-2515] Oct 10, 2016

ashumilova reviewed Oct 10, 2016

View reviewed changes

ashumilova approved these changes Oct 10, 2016

View reviewed changes

olexii4 force-pushed the CHE-2515 branch from 8d6a4db to 768499b Compare October 10, 2016 08:37

bmicklea mentioned this pull request Oct 11, 2016

Unexpected rewriting content of stack after renaming #2603

Closed

olexii4 added the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 15, 2016

olexii4 force-pushed the CHE-2515 branch from a341ebb to f8b68bf Compare October 20, 2016 15:42

olexii4 force-pushed the CHE-2515 branch from f8b68bf to 4b75410 Compare October 21, 2016 10:06

akurinnoy approved these changes Oct 21, 2016

View reviewed changes

olexii4 force-pushed the CHE-2515 branch 2 times, most recently from 337e411 to 80b195f Compare October 25, 2016 09:21

olexii4 force-pushed the CHE-2515 branch from 287a251 to 74ccff2 Compare October 27, 2016 09:46

ashumilova reviewed Oct 27, 2016

View reviewed changes

Oleksii Orel added 13 commits October 28, 2016 19:36

CHE-2515 add ability to configure machines and commands inside stack …

7b2b307

…definition Signed-off-by: Oleksii Orel <[email protected]>

remove unused code

5284dc1

Signed-off-by: Oleksii Orel <[email protected]>

add a maven exec task for TypeScript definition manager

722268c

Signed-off-by: Oleksii Orel <[email protected]>

improve workspace environments widget

8f75b06

Signed-off-by: Oleksii Orel <[email protected]>

fix default icon for ready-to-go stack selector

130dc10

Signed-off-by: Oleksii Orel <[email protected]>

CHE-2727 fix wrong behavior with stack bulk operation

196e827

Signed-off-by: Oleksii Orel <[email protected]>

CHE-2516 add ability to set stack's category

25f9167

Signed-off-by: Oleksii Orel <[email protected]>

improve configuration flow for runtimes

0a61c86

Signed-off-by: Oleksii Orel <[email protected]>

CHE-2519 add 'row' widget to the JSON editor

04ac408

Signed-off-by: Oleksii Orel <[email protected]>

CHE-2517 add ability to define stack's components

b092b65

Signed-off-by: Oleksii Orel <[email protected]>

CHE-2893 fix che-list alignement

2e43291

Signed-off-by: Oleksii Orel <[email protected]>

improve add stack flow

9d14e4f

Signed-off-by: Oleksii Orel <[email protected]>

add stack info in case with create workspace flow

0f99f90

Signed-off-by: Oleksii Orel <[email protected]>

olexii4 force-pushed the CHE-2515 branch from 295175d to 0f99f90 Compare October 28, 2016 16:51

olexii4 merged commit 10bae41 into master Oct 28, 2016

olexii4 deleted the CHE-2515 branch October 28, 2016 16:55

ashumilova added this to the 5.0.0-M7 milestone Oct 31, 2016

ashumilova mentioned this pull request Nov 9, 2016

Add ability to add and remove machines to workspace environment #2825

Closed

bmicklea mentioned this pull request Nov 16, 2016

5.0.0-M7 Milestone Plan #2935

Closed

66 tasks

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017

Merge pull request eclipse-che#2734 from eclipse/CHE-2515

da82667

Add ability to configure machines inside stack definition [CHE-2515]

Add ability to configure machines inside stack definition [CHE-2515] #2734

Add ability to configure machines inside stack definition [CHE-2515] #2734

Conversation

olexii4 commented Oct 7, 2016 • edited by ashumilova Loading

What does this PR do?

codenvy-ci commented Oct 7, 2016

TylerJewell commented Oct 7, 2016

codenvy-ci commented Oct 9, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codenvy-ci commented Oct 10, 2016

codenvy-ci commented Oct 10, 2016

codenvy-ci commented Oct 10, 2016

codenvy-ci commented Oct 20, 2016

codenvy-ci commented Oct 21, 2016

codenvy-ci commented Oct 25, 2016

codenvy-ci commented Oct 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codenvy-ci commented Oct 27, 2016

codenvy-ci commented Oct 28, 2016

codenvy-ci commented Oct 28, 2016

olexii4 commented Oct 7, 2016 •

edited by ashumilova

Loading