CODENVY-931: add snapshot creating state to workspace status #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
reviewed
Oct 10, 2016
| if (this.workspaceStatuses.indexOf(message.eventType) >= 0) { | ||
| this.getWorkspaceById(workspaceId).status = message.eventType; | ||
| } else if (message.eventType === 'SNAPSHOT_CREATED') { | ||
| this.getWorkspaceById(workspaceId).status = 'RUNNING'; |
There was a problem hiding this comment.
yes, workspace snapshot can be created for running workspace only, so it's really running. But we artificially introduce - SNAPSHOT_CREATING - to display it as status, though real status is still RUNNING. And we get back to it on SNAPSHOT_CREATED event
benoitf
approved these changes
Oct 10, 2016
| if (this.workspaceStatuses.indexOf(message.eventType) >= 0) { | ||
| this.getWorkspaceById(workspaceId).status = message.eventType; | ||
| } else if (message.eventType === 'SNAPSHOT_CREATED') { | ||
| this.getWorkspaceById(workspaceId).status = 'RUNNING'; |
|
Build # 674 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/674/ to view the results. |
|
Missing labels |
Signed-off-by: Ann Shumilova <[email protected]>
ashumilova
force-pushed
the
CODENVY-931
branch
from
a421cd5 to
e9d63c8
Compare
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
CODENVY-931: add snapshot creating state to workspace status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds snapshot creating state to workspace status indicator.
What issues does this PR fix or reference?
codenvy/codenvy#931
Previous behavior
Snapshot creating was shown as stopped workspace.
New behavior
Orange circle for snapshot in progress is displayed.
Signed-off-by: Ann Shumilova [email protected]