CHE-2654: Changing Agent REST API (adding 'id' and 'description' fiel… #2861
Conversation
|
Can one of the admins verify this patch? |
|
Agent's descriptions might be different (please, advice more suitable options in this case) |
| let agent = this.cheAgent.getAgentById(id); | ||
|
|
||
| let isEnabled = this.isEnabled(agent.id, this.agents); | ||
| this.agentsList.push({ |
There was a problem hiding this comment.
Here we can do :
let agentItem = angular.copy(agent);
agentItem.isEnable = isEnabled;
this.agentsList.push(agentItem);
|
@tolusha , @ibuziuk can |
|
@ashumilova @tolusha this can be done, but probably returning ids instead has been done deliberately for some reason ? |
|
@ibuziuk @ashumilova |
|
@tolusha how the |
|
@ibuziuk |
|
@tolusha sounds good ;-) |
|
Thank's a lot |
|
@ibuziuk Do we need |
|
It duplicates a bit |
|
@tolusha that is why I commented above:
Agent's name + " support" does not seem to be the right thing. However, we can also leave it this way for now, because changing description is just updating the json file (can be done once the right description will be found" |
|
+1 on keeping name - it is display human readable name. And some widgets may not contain description - only names as short form. |
|
@ashumilova @tolusha PR has been updated |
| @@ -1,5 +1,7 @@ | |||
| { | |||
| "name": "org.eclipse.che.ls.csharp", | |||
| "id" : "org.eclipse.che.ls.csharp", | |||
| "name": "C#", | |||
| @@ -1,5 +1,7 @@ | |||
| { | |||
| "name": "org.eclipse.che.ls.json", | |||
| "id": "org.eclipse.che.ls.json", | |||
| "name": "JSON", | |||
| @@ -1,5 +1,7 @@ | |||
| { | |||
| "name": "org.eclipse.che.ls.php", | |||
| "id": "org.eclipse.che.ls.php", | |||
| "name": "PHP", | |||
|
@tolusha thanks for review - I will update PR later today |
|
@tolusha @ashumilova PR has been updated |
|
PR has been rebased with minor corrections |
|
@ibuziuk thank you, we are waiting for M6 to release and will merge it. |
|
@ashumilova most welcome ;-) |
|
Very nice!
|
|
@ibuziuk can you align PR with master and let's merge it? |
…ds). Updating "Agents" section in the dashboard for using new API Signed-off-by: Ilya Buziuk <[email protected]>
|
@ashumilova done |
CHE-2654: Changing Agent REST API (adding 'id' and 'description' fiel…
What does this PR do?
Changes Agent REST API for using 'id' instead of 'name' (adding 'id' and 'description' fields). Updating "Agents" section in the dashboard for using new API
What issues does this PR fix or reference?
#2654
Previous behavior
Agent names looked more like internal ids / No description field
New behavior
Signed-off-by: Ilya Buziuk [email protected]