CODENVY-804 : Use of userManager to get the userId (when injecting ssh keys) #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In che Owner of a machine or namespace of a workspace is the same than the user-id ssh service is using user-id while username is given so there is never a match It fixes it by asking userManager the userId. Change-Id: I30a20a52ffc3149a8f732edeb8ab86db827c9d91 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
kind/bug
benoitf
changed the title
|
@sleshchenko kind of old bug, if you can review my PR |
|
Yes - approved. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/974/ |
sleshchenko
approved these changes
Nov 10, 2016
There was a problem hiding this comment.
OK as temporary solution. Because we should fix the main problem of this bug here https://github.com/eclipse/che/blob/master/plugins/plugin-docker/che-plugin-docker-machine/src/main/java/org/eclipse/che/plugin/docker/machine/MachineProviderImpl.java#L313-313
We should set user id for machine creator.
|
linked to #3042 |
benoitf
removed
sprint/current
status/code-review
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
In che Owner of a machine or namespace of a workspace is the same than the user-id ssh service is using user-id while username is given so there is never a match It fixes it by asking userManager the userId. Change-Id: I30a20a52ffc3149a8f732edeb8ab86db827c9d91 Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
codenvy/codenvy#804
Previous behavior
No ssh keys are injected (machine or workspace keys)
New behavior
SSH keys are injected as expected
In Eclipse Che, Owner of a machine or namespace of a workspace is the same than the user-id
ssh service is using user-id while username is given so there is never a match
It fixes it by asking userManager the userId.
Change-Id: I30a20a52ffc3149a8f732edeb8ab86db827c9d91
Signed-off-by: Florent BENOIT [email protected]