Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ssh text displayed in the IDE #3045

Merged
merged 1 commit into from
Nov 10, 2016
Merged

Change ssh text displayed in the IDE #3045

merged 1 commit into from
Nov 10, 2016

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Nov 10, 2016

What does this PR do?

Display usage of che ssh command

What issues does this PR fix or reference?

#2059

Previous behavior

Do not display correct user in the IDE ssh message (hardcoded user login)
Image may not have default user/secret login/password

New behavior

Use of che ssh command with workspace-name and machine-name

Change the text displayed to connect with SSH to a machine

  • display correct user to use
  • display ssh private key if any
  • display che ssh command

ssh-ide

Change-Id: I9a5e3aeeb8c3b7fa8503976ac190d5a8a2e4c4b1
Signed-off-by: Florent BENOIT [email protected]

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 10, 2016
Change the text displayed to connect with SSH to a machine
- display correct user to use
- display ssh private key if any
- display che ssh command

Change-Id: I9a5e3aeeb8c3b7fa8503976ac190d5a8a2e4c4b1
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf merged commit 2c3821a into master Nov 10, 2016
@benoitf benoitf removed sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 10, 2016
@benoitf benoitf added this to the 5.0.0-M7 milestone Nov 10, 2016
@codenvy-ci
Copy link

@benoitf benoitf deleted the CHE-2059-5 branch November 10, 2016 12:10
@TylerJewell TylerJewell mentioned this pull request Nov 10, 2016
14 tasks
@bmicklea bmicklea mentioned this pull request Nov 16, 2016
66 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Change the text displayed to connect with SSH to a machine
- display correct user to use
- display ssh private key if any
- display che ssh command

Change-Id: I9a5e3aeeb8c3b7fa8503976ac190d5a8a2e4c4b1
Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants