#3030 add editor context menu #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -649,6 +649,18 @@ public void initialize() { | |||
| actionManager.registerAction("noOpAction", new NoOpAction()); | |||
| actionManager.registerAction("signatureHelp", signatureHelpAction); | |||
|
|
|||
| DefaultActionGroup editorContext = new DefaultActionGroup(actionManager); | |||
There was a problem hiding this comment.
Variable name editorContext doesn't describe the data it contains.
IMO editorContextMenu or editorContextMenuGroup would be much more better.
WDYT?
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1010/ |
vparfonov
approved these changes
Nov 15, 2016
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* eclipse-che#3030 add editor context menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add editor context menu
What issues does this PR fix or reference?
#3030