Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of Chefile in new cli : new 'dir' command #3413

Merged
merged 2 commits into from
Dec 26, 2016
Merged

Use of Chefile in new cli : new 'dir' command #3413

merged 2 commits into from
Dec 26, 2016

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Dec 16, 2016

What does this PR do?

Add 'dir' command in new cli

Previous behavior

new cli hasn't the command

New behavior

docker run..... eclipse/che-cli:nightly dir <path-to-the-host-directory> <command>

Change-Id: Iec4f40cfb503fe60c51d81ef06e07043e102db6a
Signed-off-by: Florent BENOIT [email protected]

@benoitf benoitf requested a review from TylerJewell December 16, 2016 17:10
@benoitf benoitf added this to the 5.0.0-M9 milestone Dec 16, 2016
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1353/

@skabashnyuk
Copy link
Contributor

Can you describe a usecase where this command is used?

@benoitf
Copy link
Contributor Author

benoitf commented Dec 18, 2016

I clone a project locally
Then I want to boot an eclipse che instance for this project

@benoitf
Copy link
Contributor Author

benoitf commented Dec 18, 2016

https://eclipse-che.readme.io/docs/chefile

@TylerJewell
Copy link

Now that we have the Che docs updated in the che-docs branch, can you add to this PR:

  1. Update to the CLI reference markdown which includes this command
    2 Review of the Chedir markdown pages in that branch.

@benoitf
Use of Chefile in new cli : new 'dir' command
12d5201 
Change-Id: Iec4f40cfb503fe60c51d81ef06e07043e102db6a
Signed-off-by: Florent BENOIT <[email protected]>
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1383/

@benoitf
Add documentation for che dir in cli
e26734f 
(also update ssh, action and test)

Change-Id: I56198634cb99d301e4f49d69f1eb357787b55af6
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf
Copy link
Contributor Author

benoitf commented Dec 20, 2016

ok I've added documentation in PR

@bmicklea bmicklea added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 20, 2016
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1405/

TylerJewell
TylerJewell approved these changes Dec 21, 2016
View reviewed changes
dockerfiles/cli/scripts/entrypoint.sh

COMMANDS:
action <action-name> Start action on ${CHE_MINI_PRODUCT_NAME} instance
backup Backups ${CHE_MINI_PRODUCT_NAME} configuration and data to ${CHE_CONTAINER_ROOT}/backup volume mount
config Generates a ${CHE_MINI_PRODUCT_NAME} config from vars; run on any start / restart
destroy Stops services, and deletes ${CHE_MINI_PRODUCT_NAME} instance data
dir <path> <command> Use Chefile feature in the directory <path>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the path mandatory?

@TylerJewell
Copy link

The changes that are here are ok to be merged. But we also have all of the changes that need to be made in these docs. All of these docs assume you have the old CLI installed where you just type che dir. So we need to modify these docs with a couple of examples that show the full CLI syntax, and then provide explanation that we have a short-hand explanation for the rest of the commands.

Also, someone needs to go through each command and run it once to verify that the Che dir docs are still accurate.

https://github.com/eclipse/che/tree/master/docs/_docs/chedir-portable-workspaces

@benoitf - if you want to reassign this to Stevan because of your maternity holiday, that is probably ok to do now.

@bmicklea
Copy link

@slemeur there are some docs issues here - other than that this can be merged I believe.

@slemeur
Copy link
Contributor

slemeur commented Dec 26, 2016

We will not merge this PR as we moved to another repository.
I'll take the changes into che-docs.

@slemeur slemeur closed this Dec 26, 2016
@slemeur slemeur reopened this Dec 26, 2016
@slemeur
Copy link
Contributor

slemeur commented Dec 26, 2016

Docs updated here: eclipse-che/che-docs@47fdfee

@TylerJewell
Copy link

Thanks will try to review before end of day.

@slemeur
Copy link
Contributor

slemeur commented Dec 26, 2016

@TylerJewell just took the updates from @benoitf in this PR and back ported them to che-docs repo.

chedir-portable-workspace is not updated yet.

@slemeur slemeur merged commit 09c1200 into master Dec 26, 2016
@benoitf benoitf deleted the che-file branch January 9, 2017 09:03
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 23, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
@benoitf @slemeur
Use of Chefile in new cli : new 'dir' command (eclipse-che#3413)
44b02e7 
* Use of Chefile in new cli : new 'dir' command

Change-Id: Iec4f40cfb503fe60c51d81ef06e07043e102db6a
Signed-off-by: Florent BENOIT <[email protected]>

* Add documentation for che dir in cli
(also update ssh, action and test)

Change-Id: I56198634cb99d301e4f49d69f1eb357787b55af6
Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJewell TylerJewell TylerJewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@benoitf @codenvy-ci @skabashnyuk @TylerJewell @bmicklea @slemeur