Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor dockerfiles fixes #3555

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Minor dockerfiles fixes #3555

merged 1 commit into from
Jan 4, 2017

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Dec 28, 2016

Signed-off-by: Mario Loriedo [email protected]

What does this PR do?

  • Update Dockerfile.centos
  • Remove parameter on all calls to build function (because it's not used)
  • Avoid building twice lib folder in script build-all.sh
  • Fix formatting in cmd_debug.sh

@l0rd
Minor dockerfiles build fixes
af14a2e 
Signed-off-by: Mario Loriedo <[email protected]>
@l0rd l0rd requested review from TylerJewell and benoitf December 28, 2016 11:47
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@benoitf
Copy link
Contributor

benoitf commented Dec 28, 2016

I would keep arguments to build command as we may need it in the future if we add some enhancements

@l0rd
Copy link
Contributor Author

l0rd commented Dec 28, 2016

@benoitf I would add arguments to build command if/when build command will use them. Not before.

@l0rd l0rd merged commit 39416e1 into eclipse-che:master Jan 4, 2017
@bmicklea bmicklea added this to the 5.0.0 milestone Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJewell TylerJewell TylerJewell approved these changes

@benoitf benoitf benoitf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@l0rd @codenvy-ci @benoitf @TylerJewell @bmicklea