CHE-3740; fix debian scipts java install #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
reviewed
Jan 16, 2017
| @@ -98,6 +98,7 @@ elif echo ${LINUX_TYPE} | grep -qi "debian"; then | |||
|
|
|||
| if [ ${INSTALL_JDK} = true ]; then | |||
| PACKAGES=${PACKAGES}" openjdk-8-jdk-headless"; | |||
| echo "deb http://ftp.de.debian.org/debian jessie-backports main" | ${SUDO} tee --append /etc/apt/sources.list | |||
There was a problem hiding this comment.
shouldn't we use http://httpredir.debian.org/debian ?
There was a problem hiding this comment.
I used that url in a comment as an example. Yes, we should use this one I think. Or install by adding ppa.
There was a problem hiding this comment.
Ups. deb http://ftp.debian.org/debian testing main is the correct link.
There was a problem hiding this comment.
httpredir.debian.org/ is selecting the closest mirror from the user.
benoitf
approved these changes
Jan 16, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1642/ |
slemeur
added
the
kind/bug
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a OpenJDK installation fix for some Debian-based images
What issues does this PR fix or reference?
fixes #3740