CHE-3720: Decouple different agents on different maven modules

[tolusha]

What does this PR do?

Adds module per agent

What issues does this PR fix or reference?

#3720

Previous behavior

All agents are located in the same folder

Tests written?

Yes

Changelog

Decouple different agents on different maven modules

[skabashnyuk]

Can you describe new folders structure?

[tolusha]

agents
  ├── che-core-api-agent
  ├── che-core-api-agent-shared
  ├── exec
  ├── ls-csharp
  ├── ls-json
  ├── ls-php
  ├── ls-python
  ├── ls-typescript
  ├── unison
  ├── ssh
  │  ├── pom.xml
  │  └── src
  │      └── main
  │         ├── java
  │         │   └── org
  │         │       └── eclipse
  │         │           └── che
  │         │               └── api
  │         │                   └── agent
  │         │                       ├── SshAgent.java
  │         │                       ├── SshAgentLauncher.java
  │         │                       └── SshAgentDescriptorModule.java
  │         └── resources
  │             ├── org.eclipse.che.ssh.json
  │             └── org.eclipse.che.ssh.script.sh
  └── pom.xml

[tolusha]

also:

wsagent
  ...
  ├── che-core-api-debug
  ├── che-core-api-debug-shared
  ├── che-core-api-git
  ├── che-core-api-git-shared
  ├── che-core-api-languageserver
  ├── che-core-api-languageserver-shared
  ├── che-core-api-project
  ├── che-core-api-project-shared
  ├── che-core-git-impl-jgit
  ├── pom.xml
  ├── agent
  │   ├── pom.xml
  │   └── src
  │       ├── main
  │       │   ├── java
  │       │   │   └── org
  │       │   │       └── eclipse
  │       │   │           └── che
  │       │   │               └── api
  │       │   │                   └── agent
  │       │   │                       ├── WsAgent.java
  │       │   │                       ├── WsAgentLauncher.java
  │       │   │                       └── WsAgentDescriptorModule.java
  │       │   └── resources
  │       │       ├── org.eclipse.che.ws-agent.json
  │       │       └── org.eclipse.che.ws-agent.script.sh
  │       └── test
  │           └── java
  │               └── org
  │                   └── eclipse
  │                       └── che
  │                           └── api
  │                               └── agent
  │                                   └── WsAgentLauncherTest.java
  └── wsagent-local

[TylerJewell]

That documentation helps. I think @skabashnyuk - at the same time that this is merged, the wiki needs to be updated with an explanation of how this modifies the development workflow. We have sections at the end of that wiki that explain the repository layout, and they need to be updated with this information.

[codenvy-ci]

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1711/

[codenvy-ci]

Build # 1729 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1729/ to view the results.

[tolusha]

@TylerJewell
Does it mean the structure it is ok for you?

[codenvy-ci]

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1736/

[TylerJewell]

@tolusha - I think the code structure of /wsagent folder is really for @gazarenkov to comment on. The /agents folder is ok for me.

[garagatyi]

Here it is possible that someone declared 2 equal agents.
If all of them have equals and hashcode then multibinder will throw an error.
If multibinder is declared anywhere with support of duplicates then it won't throw exception.
If equals and hashcode is not overridden or overridden in a different ways then here duplicate agent will override previous one.

[garagatyi]

Looks like all the agents are very similar. Please consider creation of abstract base class for them.

[garagatyi]

Looks good. Great job!
Please consider improvements I commented.

[codenvy-ci]

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1751/

[codenvy-ci]

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1761/

[skabashnyuk]

ok