CLI - Fix error with version check on nightly #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Jewell [email protected] <[email protected]>
TylerJewell
added
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1728/ |
benoitf
reviewed
Jan 23, 2017
| @@ -369,7 +369,7 @@ verify_version_compatibility() { | |||
| CHE_IMAGE_VERSION=$(get_image_version) | |||
|
|
|||
| # Only check for newer versions if not in offline mode. | |||
There was a problem hiding this comment.
we should add in the comment : "not in offline mode and not nightly"
benoitf
approved these changes
Jan 23, 2017
|
Added to RN - can be merged |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1731/ |
riuvshin
pushed a commit
that referenced
this pull request
Jan 24, 2017
With the new commit made where we check for newer versions on DockerHub, this check was being done for all versions including nightly. The compare_versions method would break if you had a nightly image. This fix adds a test to only do this check if you are not nightly. Also, this cleans up some of the code around boot2docker checks. Unfortunately, since we are running our client inside of a Docker container, all we can do is print a warning message that you are on boot2docker and that you need to verify your host mounts. Signed-off-by: Tyler Jewell [email protected] <[email protected]>
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
With the new commit made where we check for newer versions on DockerHub, this check was being done for all versions including nightly. The compare_versions method would break if you had a nightly image. This fix adds a test to only do this check if you are not nightly. Also, this cleans up some of the code around boot2docker checks. Unfortunately, since we are running our client inside of a Docker container, all we can do is print a warning message that you are on boot2docker and that you need to verify your host mounts. Signed-off-by: Tyler Jewell [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Jewell [email protected] [email protected]
With the new commit made where we check for newer versions on DockerHub, this check was being done for all versions including nightly. The
compare_versionsmethod would break if you had a nightly image. This fix adds a test to only do this check if you are not nightly.Also, this cleans up some of the code around boot2docker checks. Unfortunately, since we are running our client inside of a Docker container, all we can do is print a warning message that you are on boot2docker and that you need to verify your host mounts.
Changelog and Release Note Information
Changelog: Skips DockerHub newer version check if using
nightlyimageRelease Note