Proper handle the workspace snapshot creation state #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
added
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1732/ |
ashumilova
approved these changes
Jan 23, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1820/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1837/ |
|
Tested with QA, regressions wasn't found. |
vparfonov
approved these changes
Feb 2, 2017
|
Changeslog |
bmicklea
approved these changes
Feb 2, 2017
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Proper handle snapshotting state when user opens ide * Proper handle snapshotting state when user opens ide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional functionality to proper handle workspace state if the last on is in the snapshotting. The problem was in that, user can access the IDE when the last one was stopping. But before stopping IDE tries to snapshot current workspace, so user couldn't recognize whether IDE is either running or stopping.
Related issue: #2763
https://slack-files.com/T02G3VAG4-F3UAKJT4J-138321a7ba
Changelog
Clarifies workspace state when IDE is loading while a workspace is being snapshotted.
N/A
Docs PR
N/A