change AGENT_EXTERNAL_PORT to real ephemeral port #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1750/ |
benoitf
approved these changes
Jan 24, 2017
TylerJewell
approved these changes
Jan 24, 2017
|
to proof that this will work I;ve opened 12345 port on firewall and issue is gone, and as we already have ephemeral ports open on our infra it will work. |
|
@riuvshin yes BTW test is closer than how it performs so it's good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TylerJewell I've made this PR because I think this should fix issues on our nightly env where we are not able to run codenvy due to failed network checs. the problem is that in test we trying to use random port
12345as ephemeral but ephemeral port rage is32768:65535and12345port is blocked by firewall while ephemeral range is available.Changelog
Change AGENT_EXTERNAL_PORT to real ephemeral port