CHE-3797 fix project import in case when workspace is running #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
approved these changes
Jan 25, 2017
benoitf
added
kind/bug
akurinnoy
approved these changes
Jan 25, 2017
ashumilova
reviewed
Jan 25, 2017
| @@ -177,7 +177,7 @@ export class CheWorkspace { | |||
| }); | |||
| } | |||
|
|
|||
| getWorkspacesByNamespace(namespace) { | |||
| getWorkspacesByNamespace(namespace: string): che.IWorkspace { | |||
There was a problem hiding this comment.
Here the list is returned.
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1769/ |
ashumilova
approved these changes
Jan 25, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1772/ |
Signed-off-by: Oleksii Orel <[email protected]>
slemeur
removed
the
status/code-review
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
CHE-3797 fix project import in case when workspace is running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Orel [email protected]
What does this PR do?
Fix project import in case when workspace is running.
What issues does this PR fix or reference?
#3797
Changelog and Release Note Information
Changelog
Fix bug with infinite expectation during project import in case with running workspace.
Release notes: