Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli/chedir] Chefile: Add support of docker compose file #3908

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Jan 26, 2017

What does this PR do?

Adds support of docker compose file in Chefile

What issues does this PR fix or reference?

#3144

Changelog and Release Note Information

Changelog

Add support of docker compose file in Chefile

Release Notes: Add support of docker compose file in Chefile

Docs Pull Request

Doc is already up-to-date at https://github.com/eclipse/che-docs/blob/master/src/main/_docs/chedir-portable-workspaces/chedir-chefiles.md

Change-Id: I9bd7185cb080ddcf77f609c88fd6531d1c75fac2
Signed-off-by: Florent BENOIT [email protected]

Change-Id: I9bd7185cb080ddcf77f609c88fd6531d1c75fac2
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. status/pending-merge labels Jan 26, 2017
@benoitf benoitf added this to the 5.2.0 milestone Jan 26, 2017
@benoitf benoitf self-assigned this Jan 26, 2017
@codenvy-ci
Copy link

@slemeur slemeur added kind/enhancement A feature request - must adhere to the feature request template. and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Jan 26, 2017
Copy link
Contributor

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to RN ok for me

@TylerJewell
Copy link

Can you paste a sample Chefile that references a dockerfile? I'd like @JamesDrummond to add it into the docs and maybe we include it in the release notes. We'll introduce this as a new feature of Chefiles.

@benoitf
Copy link
Contributor Author

benoitf commented Jan 26, 2017

@TylerJewell the documentation was already documenting the case but the implementation was not implementing it and there was an example
https://www.eclipse.org/che/docs/chedir/chefiles/index.html

Here is a sample Chefile (the same Java/Mysql docker compose than inside stacks.json but without the extra \n)

workspace.runtime.docker.composefile=`services:
 db:
  image: mysql
  environment:
   MYSQL_ROOT_PASSWORD: password
   MYSQL_DATABASE: petclinic
   MYSQL_USER: petclinic
   MYSQL_PASSWORD: password
  mem_limit: 1073741824
 dev-machine:
  image: eclipse/ubuntu_jdk8
  mem_limit: 2147483648
  depends_on:
    - db
`

@benoitf benoitf changed the title Chefile: Add support of docker compose file [cli/chedir] Chefile: Add support of docker compose file Jan 26, 2017
@TylerJewell
Copy link

Thanks - that is sufficient. I think we are good here.

@benoitf benoitf merged commit f02be66 into master Jan 26, 2017
@benoitf benoitf deleted the che#3144 branch January 26, 2017 17:01
@JamesDrummond JamesDrummond mentioned this pull request Feb 6, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants