-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli/chedir] Chefile: Add support of docker compose file #3908
Conversation
Change-Id: I9bd7185cb080ddcf77f609c88fd6531d1c75fac2 Signed-off-by: Florent BENOIT <[email protected]>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1781/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to RN ok for me
Can you paste a sample Chefile that references a dockerfile? I'd like @JamesDrummond to add it into the docs and maybe we include it in the release notes. We'll introduce this as a new feature of Chefiles. |
@TylerJewell the documentation was already documenting the case but the implementation was not implementing it and there was an example Here is a sample Chefile (the same Java/Mysql docker compose than inside stacks.json but without the extra \n)
|
Thanks - that is sufficient. I think we are good here. |
What does this PR do?
Adds support of docker compose file in Chefile
What issues does this PR fix or reference?
#3144
Changelog and Release Note Information
Changelog
Add support of docker compose file in Chefile
Release Notes: Add support of docker compose file in Chefile
Docs Pull Request
Doc is already up-to-date at https://github.com/eclipse/che-docs/blob/master/src/main/_docs/chedir-portable-workspaces/chedir-chefiles.md
Change-Id: I9bd7185cb080ddcf77f609c88fd6531d1c75fac2
Signed-off-by: Florent BENOIT [email protected]