Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli/chedir] Fix #2787 Do not write default values of che.server when writing the default Chefile #3916

Merged
merged 1 commit into from
Jan 27, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Jan 26, 2017

What does this PR do?

Do not write anymore default values into the initial Chefile file when using chedir

What issues does this PR fix or reference?

#2787

Changelog and Release Note Information

Changelog

Do not write default values into the initial Chefile file when using chedir

Release Notes:
N/A

Docs Pull Request

I'm not sure it is required to be documented ? let me know

…default Chefile

Change-Id: I
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/pending-merge labels Jan 26, 2017
@benoitf benoitf added this to the 5.2.0 milestone Jan 26, 2017
@benoitf benoitf self-assigned this Jan 26, 2017
@benoitf benoitf changed the title Fix #2787 Do not write default values of che.server when writing the default Chefile [cli/chedir] Fix #2787 Do not write default values of che.server when writing the default Chefile Jan 26, 2017
@benoitf benoitf requested a review from TylerJewell January 26, 2017 16:31
@codenvy-ci
Copy link

@slemeur slemeur added kind/bug Outline of a bug - must adhere to the bug report template. and removed kind/enhancement A feature request - must adhere to the feature request template. labels Jan 27, 2017
@slemeur
Copy link
Contributor

slemeur commented Jan 27, 2017

Ok for me
+1 no docs needed

@benoitf benoitf merged commit 1409ed8 into master Jan 27, 2017
@benoitf benoitf deleted the che#2787 branch January 27, 2017 13:15
@JamesDrummond JamesDrummond mentioned this pull request Feb 6, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants