[cli] fix issue around logs of che-server not written in host folder and update path of machines logs #3926
Conversation
…nally defined Change-Id: I73b8beed66b63f5368edb7b607fbdd96cbf69d93 Signed-off-by: Florent BENOIT <[email protected]>
Change-Id: I Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
kind/bug
benoitf
changed the title
| @@ -23,7 +22,8 @@ JPDA_ADDRESS=<%= scope.lookupvar('che::che_debug_port') %> | |||
|
|
|||
| CHE_DATABASE=/data | |||
| CHE_WORKSPACE_STORAGE=/data/workspaces | |||
| CHE_WORKSPACE_LOGS=/data/logs/machine | |||
| CHE_LOGS_DIR=/logs | |||
There was a problem hiding this comment.
If it is hardcoded here then it is not possible to reassign it in user's che.env. Am I correct?
There was a problem hiding this comment.
@garagatyi I've moved the definition few lines after its initial location so the LOGS_DIR are at the same place, I've not introduced a new hardcoded property.
AFAIK the definition of these values are "hardcoded" by CLI as it's inside the docker container. (for Che and Codenvy)
There was a problem hiding this comment.
@garagatyi you may want to be able to override these values ?
There was a problem hiding this comment.
@garagatyi yes correct, this is the fix. Before it was hardcoded in che-server docker image. Now it is set only if not provided. And cli is providing the property so it handle it correctly.
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1795/ |
|
Added to RN. |
benoitf
removed
the
status/code-review
What does this PR do?
Fix #3913 : che-server container should reuse property of CHE_LOGS_DIR if externally defined (else we couldn't configure the path externally)
Also machine logs should go in /logs/ folder as well (not in /data)
What issues does this PR fix or reference?
#3913
Changelog and Release Note Information
Changelog
Che logs should go in /logs folder. server log was not present.
Release Notes: N/A (bug)
Docs Pull Request
N/A as bugfix
https://www.eclipse.org/che/docs/setup/getting-started/index.html is not talking about logs