CHE-3994 fix create workspace with project bug #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Orel <[email protected]>
|
qa tests for dashboard have passed |
benoitf
approved these changes
Feb 2, 2017
|
@olexii4 @akurinnoy guys does this pr fixes also #3997 and #3995 ? |
akurinnoy
approved these changes
Feb 2, 2017
ashumilova
approved these changes
Feb 2, 2017
Signed-off-by: Oleksii Kurinnyi <[email protected]>
|
@ashumilova @benoitf please review |
|
great, good job @akurinnoy! |
benoitf
reviewed
Feb 2, 2017
| createWorkspace(workspaceConfig: any, attributes?: any): void { | ||
| // TODO: no account in che ? it's null when testing on localhost | ||
| createWorkspace(workspaceConfig: che.IWorkspaceConfig, attributes?: any): void { | ||
| // tODO: no account in che ? it's null when testing on localhost |
There was a problem hiding this comment.
AFAIK, it's to avoid warning from tslint
"comment-format": [
true,
"check-space",
"check-lowercase"
],There was a problem hiding this comment.
I meant : you replaced TODO by tODO (first letter lowercase)
benoitf
reviewed
Feb 2, 2017
| @@ -1067,14 +973,14 @@ export class CreateProjectController { | |||
| // generate a name | |||
|
|
|||
| // starts with project | |||
| var name = 'project'; | |||
| let name = 'project'; | |||
There was a problem hiding this comment.
Here name is inferred to be string because of its value.
Type Inference
Should we specify the type of the variable in this case?
There was a problem hiding this comment.
ok, up to you. In that case it's obvious but sometimes we declare variable used later.
benoitf
approved these changes
Feb 2, 2017
ashumilova
approved these changes
Feb 2, 2017
ashumilova
requested review from
JamesDrummond
and removed request for
slemeur
JamesDrummond
approved these changes
Feb 2, 2017
riuvshin
pushed a commit
that referenced
this pull request
Feb 2, 2017
* CHE-3994 fix create workspace with project bug Signed-off-by: Oleksii Orel <[email protected]> * fix RAM indicator Signed-off-by: Oleksii Kurinnyi <[email protected]>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1859/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* CHE-3994 fix create workspace with project bug Signed-off-by: Oleksii Orel <[email protected]> * fix RAM indicator Signed-off-by: Oleksii Kurinnyi <[email protected]>
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* CHE-3994 fix create workspace with project bug Signed-off-by: Oleksii Orel <[email protected]> * fix RAM indicator Signed-off-by: Oleksii Kurinnyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Orel [email protected]
What does this PR do?
Fix create workspace with project bug.
What issues does this PR fix or reference?
#3994
#3995
#3996
Changelog