Fix locale in CentOS based image #4056
Conversation
Signed-off-by: Mario Loriedo <[email protected]>
|
Can one of the admins verify this patch? |
l0rd
added
the
status/code-review
l0rd
changed the title
benoitf
added
the
kind/bug
| # --name che \ | ||
| # -v /var/run/docker.sock:/var/run/docker.sock \ | ||
| # -v ~/.che/workspaces:/data \ | ||
| # eclipse/che-server:nightly |
There was a problem hiding this comment.
Not sure we want to require nightly. eclipse/che-server:nightly => eclipse/che-server. Should change -v ~/.che/workspaces:/data => -v <LOCAL_PATH>:/data.
There was a problem hiding this comment.
about the first point if you use build script by default it will produce nightly so if you need to run this newly image you'll have to use that version
There was a problem hiding this comment.
Still not sure if nightly should be used. Who will use the dockerfile? Seems better to allow user to choose version. Seems like it possible but I have not investigated https://github.com/eclipse/che/blob/master/dockerfiles/build.include#L33 .
There was a problem hiding this comment.
@JamesDrummond I like ~/.che/ more because I can just copy paste and it works. I don't need an extra step of editing the command. But I understand you want to make it clear that the path is configurable. I just wanted to be sure that you understand why I prefer ~/.che/ (and potentially other users would prefer it too). If you still think that setting <LOCAL_PATH> is a better choice I will change that.
What is the issue with nightly? I understand you want to change that but I don't understand why. I'm asking because in the past I've fixed an issue with non nightly tags and I ran into another issue recently. So when I build it I usually use the default tag (nightly) to improve my chance to build/run successfully.
There was a problem hiding this comment.
This is why I ask who are the users going to be for the dockerfile. ~/.che will not work on a windows machine. Using nightly label is fine but I don't think it should be required. What if you want to produce a stable version of the centos to host on a repo such as dockerhub. Again I am not sure of the use case of this dockerfile. If you would like to keep ~/.che and nightly in place because that is what the target use will be I can approve. Just let me know.
There was a problem hiding this comment.
James this Dockerfile is an alternative to the che-server alpine based Dockerfile. The image should be used by individuals or organizations that prefer running Che on CentOS then alpine.
Instructions in the Dockerfiles should be for developers that know what they are doing and want hack the Dockerfile (to fix a bug in the Dockerfile for example). A user that just want to run the image should pull the pre-built images available from the Dockerhub and in registry.centos.org (and run it using the CLI).
l0rd
removed
the
status/code-review
What does this PR do?
What issues does this PR fix or reference?
When using CentOS based image a lot of
UnmappableCharacterExceptionare logged in che-server output when creating a new workspace. This is related to this issue in CentOS base image: CentOS/sig-cloud-instance-images#71Changelog
Fix bad locale in CentOS based image
Release Notes
Improved CentOS based Che docker image
Docs PR
That's a fix. No docs needed