CHE-3973: Fix deletion of WS folder on WS deletion #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1955/ |
| } | ||
| return doGetPathByName(workspaceName); | ||
| } | ||
|
|
||
| private String doGetPathByName(String workspaceName) throws IOException { |
There was a problem hiding this comment.
I think we can rename method doGetPathByName to getPathByName.
There was a problem hiding this comment.
Reverted back this class.
garagatyi
approved these changes
Feb 14, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1967/ |
TylerJewell
added
kind/bug
AndrienkoAleksandr
approved these changes
Feb 15, 2017
skabashnyuk
approved these changes
Feb 15, 2017
vinokurig
changed the title
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug where workpsace folder was present after workpsace delation.
Since Che is running in a docker container, the default workpspace folder is located in the container by
/data/workspaces/{workspace name}root.What issues does this PR fix or reference?
#3973
Changelog
Fix a bug where workspace folder was present after workpsace deletion
Release Notes
Bugfix N/A
Docs PR
Bugfix N/A