CHE-4015 Add deleted files to index(Regression) #4187
Conversation
| @@ -13,10 +13,6 @@ | |||
| import com.google.inject.Inject; | |||
| import com.google.inject.Singleton; | |||
There was a problem hiding this comment.
Please add yourself to authors.
| @@ -275,6 +275,20 @@ public void add(AddParams params) throws GitException { | |||
|
|
|||
There was a problem hiding this comment.
Please add yourself to authors.
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2013/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2018/ |
Signed-off-by: Mykola Morhun <[email protected]>
| @@ -275,6 +276,20 @@ public void add(AddParams params) throws GitException { | |||
|
|
|||
| try { | |||
| addCommand.call(); | |||
|
|
|||
| // to add deleted files in index it is required to perform git rm on them | |||
There was a problem hiding this comment.
If you need a comment it means that code excerpt barely can be understood. Introduce a new method.
|
Build # 2019 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2019/ to view the results. |
Signed-off-by: Mykola Morhun <[email protected]>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2020/ |
| } catch (GitAPIException exception) { | ||
| throw new GitException(exception.getMessage(), exception); | ||
| } | ||
| } | ||
|
|
||
| // to add deleted files in index it is required to perform git rm on them |
Signed-off-by: Mykola Morhun <[email protected]>
|
Build # 2024 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2024/ to view the results. |
bmicklea
requested review from
JamesDrummond
and removed request for
bmicklea
|
Think we need this in release notes. I have been using a work around by clicking the update checkbox. Didn't know it was work around. Added release notes above. |
JamesDrummond
added
the
kind/bug
|
This is not a regression right as there was never a way to do this before? |
|
I think it is kind of regression, because before switching to jGit it worked as expected. |
JamesDrummond
changed the title
|
@mmorhun Thanks. I updated title and description above. |
CHE-4015: Fix deleted file is not added to index
What does this PR do?
Adds ability to add tracked deleted project-file to index.
What issues does this PR fix or reference?
#4015
Changelog
Fixed bug in
Git->Add To Indexmenu command that was not adding deleted files to index.Release Notes
Fixed bug in
Git->Add To Indexmenu command that was not adding deleted files to index. This was an uncaught regression when Eclipse Che started using jGit.Docs PR
N/A