Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add ability to skip config regeneration when starting #4244

Merged
merged 4 commits into from
Mar 1, 2017

Conversation

TylerJewell
Copy link

@TylerJewell TylerJewell commented Feb 28, 2017

Signed-off-by: Tyler Jewell [email protected]

What does this PR do?

In some cases, developers want to be able to modify the generated files placed into /instance and not have the CLI overwrite these changes during the start sequence. This change adds a --skip:config option to the start and restart commands to allow this.

Also moves the --skip:preflight and --skip:postflight detection out of the bootstrap sequence into the pre sequence for the start() command as these values are not global, but specific to only a few commands.

Changelog

[cli] Add --skip:config option to start, restart, and config commands

Release Notes

You can now skip the automatic generation of configuration files when starting Che. When Che starts, we use Puppet to generate OS-specific files for running the Che servers. For example, the file /instance/docker-compose.yml is generated from a puppet template with its internal values having different values based upon the parameters of the CLI or what you have set in che.env. We update these files on every start, restart, or config command. This flag will skip this regeneration.

Docs PR

eclipse-che/che-docs#160

Tyler Jewell added 2 commits February 28, 2017 00:15
Signed-off-by: Tyler Jewell <[email protected]>
@TylerJewell TylerJewell requested a review from sunix February 28, 2017 08:21
@TylerJewell TylerJewell added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 28, 2017
@TylerJewell TylerJewell self-assigned this Feb 28, 2017
@codenvy-ci
Copy link

Tyler Jewell added 2 commits February 28, 2017 08:45
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
@codenvy-ci
Copy link

@TylerJewell TylerJewell merged commit dcf6c63 into master Mar 1, 2017
@TylerJewell TylerJewell deleted the cli-skipconfig branch March 1, 2017 08:41
@TylerJewell TylerJewell added this to the 5.4.0 milestone Mar 1, 2017
TylerJewell pushed a commit to eclipse-che/che-docs that referenced this pull request Mar 1, 2017
@JamesDrummond JamesDrummond mentioned this pull request Mar 8, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants