allow using args for start command in cmd_upgrade #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now there is no way to pass any arg to start command on upgrade, but on our prod we must skip preflight checks because they will not work due to closed ports on firewall. those changes allow using `upgrade --skip-backup --skip:preflight`
riuvshin
added
the
kind/bug
TylerJewell
approved these changes
Mar 6, 2017
benoitf
approved these changes
Mar 6, 2017
|
Build finished. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2120/ |
garagatyi
approved these changes
Mar 7, 2017
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* allow using args for start command in cmd_upgrade for now there is no way to pass any arg to start command on upgrade, but on our prod we must skip preflight checks because they will not work due to closed ports on firewall. those changes allow using `upgrade --skip-backup --skip:preflight`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now there is no way to pass any arg to start command on upgrade, but on our prod we must skip preflight checks because they will not work due to closed ports on firewall. those changes allow using
upgrade --skip-backup --skip:preflightWhat does this PR do?
allow using args for start command in cmd_upgrade
Changelog
allow using args for start command in cmd_upgrade