Prevent multiple event subscription for single file #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
vzhukovs
added
kind/bug
vparfonov
reviewed
Mar 14, 2017
|
|
||
| switch (event.getOperationType()) { | ||
| case OPEN: { | ||
| processFileOpen(path); | ||
| if (editorAgent.getOpenedEditor(path) == null) { // if we haven't any editor for given path yet | ||
| Log.info(getClass(), "Subscribe file for event handling"); // we subscribe for event handling otherwise we |
There was a problem hiding this comment.
Yes, you're right. Thanks.
vparfonov
approved these changes
Mar 14, 2017
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2176/ |
dkulieshov
approved these changes
Mar 16, 2017
vparfonov
approved these changes
Mar 18, 2017
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Prevent multiple event subscription for single file Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR proposal adds additional check for opened editor for file which opens more than once.
This will prevent multiple event subscription for single file.
Signed-off-by: Vladyslav Zhukovskii [email protected]
What issues does this PR fix or reference?
#4254
Changelog
Prevent multiple event subscription for single file
Release Notes
Prevent multiple event subscription for single file
Docs PR
N/A