Spring Boot stack #4426
Spring Boot stack #4426
Conversation
|
Recipe pull request: eclipse-che/che-dockerfiles#76 |
|
Can one of the admins verify this patch? |
| }, | ||
| { | ||
| "name": "JDK", | ||
| "version": "1.8.0_45" |
There was a problem hiding this comment.
I've used the same version as in other stacks in that file: https://github.com/eclipse/che/blob/master/ide/che-core-ide-stacks/src/main/resources/stacks.json#L89
There was a problem hiding this comment.
I would drop the _45 as from the docker recipe we don't know the version
| }, | ||
| { | ||
| "name": "Maven", | ||
| "version": "3.2.2" |
There was a problem hiding this comment.
| ] | ||
| }, | ||
| "stackIcon": { | ||
| "name": "type-java.svg", |
There was a problem hiding this comment.
question: logo is java but shouldn't it be spring boot logo ?
There was a problem hiding this comment.
Do you use a designer for these images or should I find one online?
There was a problem hiding this comment.
@gytis I'm happy to help you on that - no problem.
Could you tell me which icon do you wan to use?
- The spring leaf: https://en.wikipedia.org/wiki/File:Pivotal_Java_Spring_Logo.png
- The spring "power" button: http://stormpath.com/wp-content/uploads/2016/05/spring-boot-logo.jpg
Also, if you can point me to an SVG file, that would be ideal.
There was a problem hiding this comment.
Since it's a Spring Boot stack, "power" button is more appropriate. Either green or black (like here https://spring.io/projects) up to you.
Signed-off-by: Gytis Trikleris <[email protected]>
Signed-off-by: Stevan Le Meur <[email protected]>
|
Added dedicated spring-boot icon |
| <path d="M287.766184,130.123154 C294.116198,141.121701 294.113821,158.957986 287.766184,169.952417 L236.261619,259.160939 C229.911605,270.159486 214.463741,279.07557 201.768466,279.07557 L98.7593373,279.07557 C86.0593088,279.07557 70.6138211,270.155369 64.2661837,259.160939 L12.7616194,169.952417 C6.41160517,158.953869 6.41398201,141.117584 12.7616194,130.123154 L64.2661837,40.9146315 C70.6161979,29.9160842 86.0640625,21 98.7593373,21 L201.768466,21 C214.468494,21 229.913982,29.920201 236.261619,40.9146315 L287.766184,130.123154 Z M226.5498,145.751994 C226.5498,121.343483 215.299786,98.8434562 195.712709,84.1782601 C190.087703,79.8590586 181.951532,80.9639706 177.732777,86.6894238 C173.413576,92.3144305 174.618934,100.450601 180.243941,104.669356 C193.301992,114.513118 200.835483,129.479653 200.835483,145.751994 C200.835483,174.077921 177.732777,197.180627 149.406851,197.180627 C121.080924,197.180627 97.9782179,174.077921 97.9782179,145.751994 C97.9782179,129.479653 105.511709,114.513118 118.56976,104.669356 C124.194767,100.450601 125.400126,92.3144305 121.080924,86.6894238 C116.862169,80.9639706 108.826445,79.8590586 103.100992,84.1782601 C83.5139149,98.8434562 72.2639015,121.343483 72.2639015,145.751994 C72.2639015,188.240884 106.917961,222.894943 149.406851,222.894943 C191.895741,222.894943 226.5498,188.240884 226.5498,145.751994 Z M163.517823,72.3109722 C163.517823,65.5784093 157.123789,60 149.406851,60 C141.689913,60 135.295878,65.5784093 135.295878,72.3109722 L135.295878,143.441022 C135.295878,150.173585 141.689913,155.751994 149.406851,155.751994 C157.123789,155.751994 163.517823,150.173585 163.517823,143.441022 L163.517823,72.3109722 Z" id="spring-boot"></path> | ||
| </g> | ||
| </g> | ||
| </svg> |
There was a problem hiding this comment.
there is a missing newline
Signed-off-by: Stevan Le Meur <[email protected]>
slemeur
added
the
kind/enhancement
* Spring Boot stack Signed-off-by: Gytis Trikleris <[email protected]> * Add dedicated icon for spring-boot stack Signed-off-by: Stevan Le Meur <[email protected]> * Add newline at end of svg file Signed-off-by: Stevan Le Meur <[email protected]>
What does this PR do?
Adds the Spring Boot stack to the default Che assembly.
What issues does this PR fix or reference?
Changelog
Adds the Spring Boot stack to the default Che assembly.
Release Notes
We've added a new stack for the Spring Boot framework. You can now build Spring Boot applications by simply creating a workspace from the Spring Boot stack - no configuration necessary!
Docs PR